Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set ForceAttemptHTTP2 to increase ARM throttling limit #3006

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/azureclients/armclient/azure_armclient.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func sender() autorest.Sender {
Timeout: 30 * time.Second, // the same as default transport
KeepAlive: 30 * time.Second, // the same as default transport
}).DialContext,
ForceAttemptHTTP2: true, // always attempt HTTP/2 even though custom dialer is provided
ForceAttemptHTTP2: false, // respect custom dialer (default is true)
MaxIdleConns: 100, // Zero means no limit, the same as default transport
MaxIdleConnsPerHost: 100, // Default is 2, ref:https://cs.opensource.google/go/go/+/go1.18.4:src/net/http/transport.go;l=58
IdleConnTimeout: 90 * time.Second, // the same as default transport
Expand Down