Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.24] cherry pick #3212 and #3232 to release-1.24 #3245

Merged

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jan 29, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Cherry pick #3212 and #3232 to release-1.24.
#3212: fix: skip removing nics from lb if there will be no nics in the backend pool
#3232: fix: update network api to 2022-07-01 to support backend pool level virtual network id

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: skip removing nics from lb if there will be no nics in the backend pool
update network api to 2022-07-01 to support backend pool level virtual network id

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 29, 2023
@coveralls
Copy link

Coverage Status

Coverage: 80.086% (+0.06%) from 80.025% when pulling b83586c on nilo19:cherry-pick-3212-3232-1.24 into ffa3651 on kubernetes-sigs:release-1.24.

@nilo19 nilo19 changed the title [release-1.23] cherry pick #3212 and #3232 to release-1.24 [release-1.24] cherry pick #3212 and #3232 to release-1.24 Jan 29, 2023
@nilo19
Copy link
Contributor Author

nilo19 commented Jan 29, 2023

/retest

@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit dee501e into kubernetes-sigs:release-1.24 Jan 30, 2023
@nilo19 nilo19 deleted the cherry-pick-3212-3232-1.24 branch January 30, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants