Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove vmss vm from cache when invalidate the cache #3300

Merged
merged 1 commit into from Feb 9, 2023
Merged

fix: remove vmss vm from cache when invalidate the cache #3300

merged 1 commit into from Feb 9, 2023

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Feb 9, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Remove vmss VM from cache when deleting nodes to prevent from unexpected API call

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: remove vmss vm from cache when invalidate the cache

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2023
@coveralls
Copy link

Coverage Status

Coverage: 79.975% (+0.005%) from 79.97% when pulling 2230372 on nilo19:fix/cherry-pick-2950-1.24 into 5dcffa6 on kubernetes-sigs:release-1.24.

@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@nilo19
Copy link
Contributor Author

nilo19 commented Feb 9, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 74ec957 into kubernetes-sigs:release-1.24 Feb 9, 2023
@nilo19 nilo19 deleted the fix/cherry-pick-2950-1.24 branch February 9, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@lzhecheng lzhecheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilo19 @k8s-ci-robot @coveralls @lzhecheng