Fix: remove shared security rule when no svc with shared-nsg annotation exists

[MartinForReal]

What type of PR is this?

/kind bug

What this PR does / why we need it:

remove shared security rule when no svc with shared-nsg annotation exists

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix: remove unsed shared nsg rule when there is no svc having azure-shared-securityrule annotations set

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[netlify]

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name	Link
🔨 Latest commit	a894df4
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/63f45b2745d55800088fba1f

[coveralls]

Coverage: 79.525% (-0.0008%) from 79.526% when pulling f7a7d93 on MartinForReal:remove_shared_rule into 7a494eb on kubernetes-sigs:master.

[MartinForReal]

/kind bug

[feiskyer]

Could you add an e2e test for the issue?

[MartinForReal]

cloud-provider-azure/tests/e2e/network/network_security_group.go

Line 175 in 7a494eb

isDeleted := false

there is already one test case for this scenario.

[MartinForReal]

/cherrypick release-1.26

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.26 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/cherrypick release-1.25

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.25 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/cherrypick release-1.24

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.24 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/cherrypick release-1.23

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.23 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feiskyer]

LGTM

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MartinForReal,feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nilo19]

/lgtm

[MartinForReal]

e2e case is modified.

[jwtty]

/lgtm

[k8s-infra-cherrypick-robot]

@MartinForReal: #3391 failed to apply on top of branch "release-1.25":

Applying: fix: remove shared security rule when svc with shared-nsg annotation is deleted
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	tests/e2e/network/network_security_group.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/network_security_group.go
CONFLICT (content): Merge conflict in tests/e2e/network/network_security_group.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: remove shared security rule when svc with shared-nsg annotation is deleted
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@MartinForReal: #3391 failed to apply on top of branch "release-1.24":

Applying: fix: remove shared security rule when svc with shared-nsg annotation is deleted
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	tests/e2e/network/network_security_group.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/network_security_group.go
CONFLICT (content): Merge conflict in tests/e2e/network/network_security_group.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: remove shared security rule when svc with shared-nsg annotation is deleted
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@MartinForReal: #3391 failed to apply on top of branch "release-1.23":

Applying: fix: remove shared security rule when svc with shared-nsg annotation is deleted
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	tests/e2e/network/network_security_group.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/network_security_group.go
CONFLICT (content): Merge conflict in tests/e2e/network/network_security_group.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: remove shared security rule when svc with shared-nsg annotation is deleted
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@MartinForReal: #3391 failed to apply on top of branch "release-1.26":

Applying: fix: remove shared security rule when svc with shared-nsg annotation is deleted
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	tests/e2e/network/network_security_group.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/network_security_group.go
CONFLICT (content): Merge conflict in tests/e2e/network/network_security_group.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: remove shared security rule when svc with shared-nsg annotation is deleted
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.