Deprecate numberOfProbes and adopt ProbeThreshold to address a probe issue in nrp

[MartinForReal]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Deprecate numberOfProbes and adopt ProbeThreshold to address a probe issue in nrp
Because numberofprobes never works and it is mentioned in https://learn.microsoft.com/en-us/azure/load-balancer/whats-new#known-issues

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Deprecate numberOfProbes and adopt ProbeThreshold in network api to address a probe issue in nrp

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[netlify]

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name	Link
🔨 Latest commit	1feba16
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/641d085ff2076e0008a4c37c

[coveralls]

Coverage: 79.524%. Remained the same when pulling 1feba16 on MartinForReal:numofprobe into e75e419 on kubernetes-sigs:master.

[MartinForReal]

/cherrypick release-1.26

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.26 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/cherrypick release-1.25

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.25 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/cherrypick release-1.24

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.24 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/cherrypick release-1.23

[k8s-infra-cherrypick-robot]

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.23 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/test pull-cloud-provider-azure-e2e-capz

[MartinForReal]

/retest

[feiskyer]

/hold

[nilo19]

Can you add an explanation of why we should do this?

[MartinForReal]

/kind bug

[feiskyer]

/hold cancel
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MartinForReal,feiskyer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

/cherrypick release-1.1

[k8s-infra-cherrypick-robot]

@feiskyer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feiskyer]

@MartinForReal could you check why tests are failing?

/lgtm cancel

[MartinForReal]

/retest

[MartinForReal]

/test pull-cloud-provider-azure-e2e-capz

[MartinForReal]

/test pull-cloud-provider-azure-e2e-capz

[MartinForReal]

/retest

[feiskyer]

/lgtm

[k8s-infra-cherrypick-robot]

@feiskyer: #3623 failed to apply on top of branch "release-1.1":

Applying: deprecate numberOfProbes and adopt ProbeThreshold to address a probe issue in nrp
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	tests/e2e/network/service_annotations.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/service_annotations.go
CONFLICT (content): Merge conflict in tests/e2e/network/service_annotations.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 deprecate numberOfProbes and adopt ProbeThreshold to address a probe issue in nrp
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@MartinForReal: new pull request created: #3656

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@MartinForReal: new pull request created: #3657

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@MartinForReal: new pull request created: #3658

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@MartinForReal: #3623 failed to apply on top of branch "release-1.23":

Applying: deprecate numberOfProbes and adopt ProbeThreshold to address a probe issue in nrp
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	tests/e2e/network/service_annotations.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/service_annotations.go
CONFLICT (content): Merge conflict in tests/e2e/network/service_annotations.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 deprecate numberOfProbes and adopt ProbeThreshold to address a probe issue in nrp
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.