[IPv6] Choose correct primary IP config #3715

lzhecheng · 2023-04-07T06:53:21Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Choose correct primary IP config in ensureBackendPoolDeletedFromNode(). Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.

Which issue(s) this PR fixes:

Fixes #
Related: #3707

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Choose correct primary IP config in ensureBackendPoolDeletedFromNode(). Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

netlify · 2023-04-07T06:53:28Z

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name	Link
🔨 Latest commit	`99ef413`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/643e886458bf2c0008595c30

pkg/provider/azure_vmss.go

lzhecheng · 2023-04-14T08:17:19Z

/retest

nilo19 · 2023-04-18T03:26:19Z

pkg/provider/azure_vmss.go

+	isIPv6 := isBackendPoolIPv6(backendPoolID)
+
+	if !isIPv6 {
+		// There should be one and only once primary IP config.


nit: there can only be at most one

nilo19 · 2023-04-18T06:46:50Z

pkg/provider/azure_vmss.go

 		}
 	}

-	return nil, fmt.Errorf("failed to find a IPconfiguration(IPv6=%v) for the scale set VM %q", IPv6, nodeName)
+	return nil, fmt.Errorf("failed to find a primary IP configuration (IPv6=%v) for the VMSS VM or VMSS %q", isIPv6, resource)


nilo19 · 2023-04-18T07:03:14Z

pkg/provider/azure_vmss.go

-		if primaryIPConfig.LoadBalancerBackendAddressPools != nil {
-			loadBalancerBackendAddressPools = *primaryIPConfig.LoadBalancerBackendAddressPools
-		}
+		handleBackendPool := func(backendPoolID string) bool {


Can we extract it to a standalone function and reuse it across all the references?

Good idea. I updated 3 places but don't touch the one (ensureBackendPoolDeletedFromVmssUniform) which is different (with a vmssNamesMap). Also, I added a UT for this new function.

Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration. Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>

feiskyer

/lgtm

thanks for the fix!

k8s-ci-robot · 2023-04-20T01:54:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [feiskyer,lzhecheng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lzhecheng · 2023-04-20T05:27:51Z

/cherrypick release-1.26

lzhecheng · 2023-04-20T05:27:55Z

/cherrypick release-1.25

lzhecheng · 2023-04-20T05:28:00Z

/cherrypick release-1.24

lzhecheng · 2023-04-20T05:28:04Z

/cherrypick release-1.23

k8s-infra-cherrypick-robot · 2023-04-20T05:28:28Z

@lzhecheng: #3715 failed to apply on top of branch "release-1.26":

Applying: Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.
Using index info to reconstruct a base tree...
M	pkg/provider/azure_vmss.go
M	pkg/provider/azure_vmss_test.go
M	pkg/provider/azure_vmssflex.go
M	pkg/provider/azure_vmssflex_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_vmssflex_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmssflex_test.go
Auto-merging pkg/provider/azure_vmssflex.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmssflex.go
Auto-merging pkg/provider/azure_vmss_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss_test.go
Auto-merging pkg/provider/azure_vmss.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-infra-cherrypick-robot · 2023-04-20T05:28:32Z

@lzhecheng: #3715 failed to apply on top of branch "release-1.25":

Applying: Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.
Using index info to reconstruct a base tree...
M	pkg/provider/azure_vmss.go
M	pkg/provider/azure_vmss_test.go
M	pkg/provider/azure_vmssflex.go
M	pkg/provider/azure_vmssflex_cache_test.go
M	pkg/provider/azure_vmssflex_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_vmssflex_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmssflex_test.go
Auto-merging pkg/provider/azure_vmssflex_cache_test.go
Auto-merging pkg/provider/azure_vmssflex.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmssflex.go
Auto-merging pkg/provider/azure_vmss_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss_test.go
Auto-merging pkg/provider/azure_vmss.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-infra-cherrypick-robot · 2023-04-20T05:28:39Z

@lzhecheng: #3715 failed to apply on top of branch "release-1.24":

Applying: Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.
Using index info to reconstruct a base tree...
M	pkg/provider/azure_vmss.go
M	pkg/provider/azure_vmss_test.go
A	pkg/provider/azure_vmssflex.go
A	pkg/provider/azure_vmssflex_cache_test.go
A	pkg/provider/azure_vmssflex_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/provider/azure_vmssflex_test.go deleted in HEAD and modified in Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.. Version Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration. of pkg/provider/azure_vmssflex_test.go left in tree.
CONFLICT (modify/delete): pkg/provider/azure_vmssflex_cache_test.go deleted in HEAD and modified in Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.. Version Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration. of pkg/provider/azure_vmssflex_cache_test.go left in tree.
CONFLICT (modify/delete): pkg/provider/azure_vmssflex.go deleted in HEAD and modified in Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.. Version Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration. of pkg/provider/azure_vmssflex.go left in tree.
Auto-merging pkg/provider/azure_vmss_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss_test.go
Auto-merging pkg/provider/azure_vmss.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-infra-cherrypick-robot · 2023-04-20T05:28:43Z

@lzhecheng: #3715 failed to apply on top of branch "release-1.23":

Applying: Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.
Using index info to reconstruct a base tree...
M	pkg/provider/azure_vmss.go
M	pkg/provider/azure_vmss_test.go
A	pkg/provider/azure_vmssflex.go
A	pkg/provider/azure_vmssflex_cache_test.go
A	pkg/provider/azure_vmssflex_test.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/provider/azure_vmssflex_test.go deleted in HEAD and modified in Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.. Version Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration. of pkg/provider/azure_vmssflex_test.go left in tree.
CONFLICT (modify/delete): pkg/provider/azure_vmssflex_cache_test.go deleted in HEAD and modified in Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.. Version Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration. of pkg/provider/azure_vmssflex_cache_test.go left in tree.
CONFLICT (modify/delete): pkg/provider/azure_vmssflex.go deleted in HEAD and modified in Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.. Version Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration. of pkg/provider/azure_vmssflex.go left in tree.
Auto-merging pkg/provider/azure_vmss_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss_test.go
Auto-merging pkg/provider/azure_vmss.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Choose correct primary IP config Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 7, 2023

k8s-ci-robot requested review from feiskyer and MartinForReal April 7, 2023 06:53

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023

lzhecheng force-pushed the fix-ipv6-vmss-choose-backendpool branch from 0fe4c3c to f121ba8 Compare April 7, 2023 07:14

lzhecheng changed the title ~~[WIP][IPv6] Choose correct primary IP config in ensureBackendPoolDeletedFromNode()~~ [IPv6] Choose correct primary IP config in ensureBackendPoolDeletedFromNode() Apr 7, 2023

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2023

lzhecheng force-pushed the fix-ipv6-vmss-choose-backendpool branch from f121ba8 to 3007954 Compare April 10, 2023 08:38

lzhecheng changed the title ~~[IPv6] Choose correct primary IP config in ensureBackendPoolDeletedFromNode()~~ [IPv6] Choose correct primary IP config Apr 10, 2023

lzhecheng force-pushed the fix-ipv6-vmss-choose-backendpool branch 2 times, most recently from 442a72a to 589f009 Compare April 11, 2023 05:57

nilo19 reviewed Apr 12, 2023

View reviewed changes

pkg/provider/azure_vmss.go Outdated Show resolved Hide resolved

lzhecheng force-pushed the fix-ipv6-vmss-choose-backendpool branch from 589f009 to 6d1c2b3 Compare April 14, 2023 02:45

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2023

lzhecheng force-pushed the fix-ipv6-vmss-choose-backendpool branch 3 times, most recently from 0b77b12 to d8167f6 Compare April 14, 2023 06:13

nilo19 reviewed Apr 18, 2023

View reviewed changes

lzhecheng force-pushed the fix-ipv6-vmss-choose-backendpool branch from d8167f6 to 5a53ffb Compare April 18, 2023 06:43

nilo19 reviewed Apr 18, 2023

View reviewed changes

lzhecheng force-pushed the fix-ipv6-vmss-choose-backendpool branch from 5a53ffb to 8f10b38 Compare April 18, 2023 10:13

[IPv6] Choose correct primary IP config

99ef413

Regardless of IPv6 only or dualstack clusters, IPv4 IP config is always primary. So for IPv6 backend address pool, IP config's IP version needs consideration. Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>

lzhecheng force-pushed the fix-ipv6-vmss-choose-backendpool branch from 8f10b38 to 99ef413 Compare April 18, 2023 12:09

kubernetes-sigs deleted a comment from coveralls Apr 18, 2023

feiskyer approved these changes Apr 20, 2023

View reviewed changes

k8s-ci-robot assigned feiskyer Apr 20, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023

k8s-ci-robot merged commit 243bfa8 into kubernetes-sigs:master Apr 20, 2023
19 checks passed

lzhecheng deleted the fix-ipv6-vmss-choose-backendpool branch April 20, 2023 05:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IPv6] Choose correct primary IP config #3715

[IPv6] Choose correct primary IP config #3715

lzhecheng commented Apr 7, 2023 •

edited

netlify bot commented Apr 7, 2023 •

edited

lzhecheng commented Apr 14, 2023

nilo19 Apr 18, 2023

lzhecheng Apr 18, 2023

nilo19 Apr 18, 2023

lzhecheng Apr 18, 2023

nilo19 Apr 18, 2023

lzhecheng Apr 18, 2023

feiskyer left a comment

k8s-ci-robot commented Apr 20, 2023

lzhecheng commented Apr 20, 2023

lzhecheng commented Apr 20, 2023

lzhecheng commented Apr 20, 2023

lzhecheng commented Apr 20, 2023

k8s-infra-cherrypick-robot commented Apr 20, 2023

k8s-infra-cherrypick-robot commented Apr 20, 2023

k8s-infra-cherrypick-robot commented Apr 20, 2023

k8s-infra-cherrypick-robot commented Apr 20, 2023

[IPv6] Choose correct primary IP config #3715

[IPv6] Choose correct primary IP config #3715

Conversation

lzhecheng commented Apr 7, 2023 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

netlify bot commented Apr 7, 2023 • edited

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

lzhecheng commented Apr 14, 2023

nilo19 Apr 18, 2023

Choose a reason for hiding this comment

lzhecheng Apr 18, 2023

Choose a reason for hiding this comment

nilo19 Apr 18, 2023

Choose a reason for hiding this comment

lzhecheng Apr 18, 2023

Choose a reason for hiding this comment

nilo19 Apr 18, 2023

Choose a reason for hiding this comment

lzhecheng Apr 18, 2023

Choose a reason for hiding this comment

feiskyer left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 20, 2023

lzhecheng commented Apr 20, 2023

lzhecheng commented Apr 20, 2023

lzhecheng commented Apr 20, 2023

lzhecheng commented Apr 20, 2023

k8s-infra-cherrypick-robot commented Apr 20, 2023

k8s-infra-cherrypick-robot commented Apr 20, 2023

k8s-infra-cherrypick-robot commented Apr 20, 2023

k8s-infra-cherrypick-robot commented Apr 20, 2023

lzhecheng commented Apr 7, 2023 •

edited

netlify bot commented Apr 7, 2023 •

edited