Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.27] Remove shared nsg rule immediately when no destinations prefixes are left #3797

Merged
merged 1 commit into from Apr 23, 2023
Merged

[release-1.27] Remove shared nsg rule immediately when no destinations prefixes are left #3797

merged 1 commit into from Apr 23, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #3787

/assign MartinForReal

Fixed: Remove shared nsg rule immediately when no destinations left

@MartinForReal
fix:remove shared nsg rule immediately when no destinations left
08aff6c 
Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 23, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 23, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 23, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-kind size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2023
@MartinForReal
Copy link
Contributor

/kind bug

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind labels Apr 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2023
@nilo19 nilo19 closed this Apr 23, 2023
@nilo19 nilo19 reopened this Apr 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit aa8b7c7 into kubernetes-sigs:release-1.27 Apr 23, 2023
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @MartinForReal @k8s-ci-robot @nilo19