Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.26] Allow deprecated beta topology labels to be applied for those not ready to migrate #4040

Merged
merged 1 commit into from Jun 6, 2023
Merged

[release-1.26] Allow deprecated beta topology labels to be applied for those not ready to migrate #4040

merged 1 commit into from Jun 6, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #3685

/assign nilo19

The deprecated beta topology labels are no longer applied by default, to maintain the legacy behaviour use `--deprecated-apply-beta-topology-labels`

@JoelSpeed
Allow deprecated beta topology labels to be applied for those not rea…
7b95212 
…dy to migrate

This reverts commit 67c2407.
It then introduces a new flag to allow users to opt-in to syncing older, beta
topology labels based on the presence of the GA topolgoy labels.
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 6, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2023
@nilo19
Copy link
Contributor

nilo19 commented Jun 6, 2023

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 6, 2023
@nilo19
Copy link
Contributor

nilo19 commented Jun 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind labels Jun 6, 2023
@nilo19
Copy link
Contributor

nilo19 commented Jun 6, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9c5b598 into kubernetes-sigs:release-1.26 Jun 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwtty jwtty Awaiting requested review from jwtty

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @nilo19 @k8s-ci-robot @JoelSpeed