Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: add logVerbosity to cloud-node-manager #4111

Merged
merged 1 commit into from Jun 16, 2023

Conversation

lzhecheng
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

helm: add logVerbosity to cloud-node-manager

Which issue(s) this PR fixes:

Fixes #3713

Special notes for your reviewer:

Does this PR introduce a user-facing change?

helm: add logVerbosity to cloud-node-manager

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2023
@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit 12eaf01
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/648bc47e78232e0008c611fa

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2023
@lzhecheng
Copy link
Contributor Author

lzhecheng commented Jun 15, 2023

/assign @jackfrancis
I put log verbosity as an env var.

Co-authored-by: Zhecheng Li <zhechengli@microsoft.com>
@jwtty
Copy link
Member

jwtty commented Jun 16, 2023

LGTM

@nilo19
Copy link
Contributor

nilo19 commented Jun 16, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit b2848c4 into kubernetes-sigs:master Jun 16, 2023
10 of 11 checks passed
@lzhecheng lzhecheng deleted the cnm-log-level branch June 16, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart for CNM log level
5 participants