Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make vmType optional #4214

Merged
merged 1 commit into from Jul 4, 2023

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Jul 4, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: make vmType optional

vmType's default value is changed from 'standard' to 'vmss' since v1.28.

Which issue(s) this PR fixes:

Fixes #3099

Special notes for your reviewer:

Does this PR introduce a user-facing change?

vmType's default value is changed from 'standard' to 'vmss' since v1.28.

action required: if your cluster is not using any VMSS instances and 'vmType' is not configured in the cloud provider config file, please add vmType=standard in the config file before upgrading to v1.28.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


vmType's default value is changed from 'standard' to 'vmss'
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2023
@feiskyer feiskyer added this to the v1.28 milestone Jul 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2023
@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 545a717 into kubernetes-sigs:master Jul 4, 2023
15 of 16 checks passed
@feiskyer feiskyer deleted the default-vmss branch July 5, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make vmType optional
3 participants