Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.26] Fix IPv6/dual-stack EnsureBackendPoolDeleted() failure #4321

Merged
merged 1 commit into from Jul 20, 2023
Merged

[release-1.26] Fix IPv6/dual-stack EnsureBackendPoolDeleted() failure #4321

merged 1 commit into from Jul 20, 2023

Conversation

lzhecheng
Copy link
Contributor

What type of PR is this?

/kind bug
/kind testing

What this PR does / why we need it:

Fix IPv6/dual-stack EnsureBackendPoolDeleted() failure

  • IP config of IPv6 is not primary, it should not be skipped in EnsureBackendPoolDeleted(). Updated e2e code.
  • Fix health probe e2e

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix IPv6/dual-stack EnsureBackendPoolDeleted() failure. IP config of IPv6 is not primary, it should not be skipped in EnsureBackendPoolDeleted()

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@lzhecheng
Fix IPv6/dual-stack EnsureBackendPoolDeleted() failure
94b3408 
* IP config of IPv6 is not primary, it should not be
skipped in EnsureBackendPoolDeleted(). Updated e2e code.
* Fix health probe e2e

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2023
feiskyer
feiskyer approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7378cd into kubernetes-sigs:release-1.26 Jul 20, 2023
12 checks passed
@lzhecheng lzhecheng deleted the cp-4272-1.26 branch July 20, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer approved these changes

@jwtty jwtty Awaiting requested review from jwtty

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/testing lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lzhecheng @k8s-ci-robot @feiskyer