Feat: add load balancer backend pool batch updater #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
MartinForReal
changed the title
nilo19
force-pushed
the
feat/multi-slb/local-svc/batch
branch
2 times, most recently
from
6d8eea5
to
85c4b24
Compare
|
/retest |
feiskyer
reviewed
Aug 1, 2023
| } | ||
|
|
||
| // newLoadBalancerBackendPoolUpdater creates a new loadBalancerBackendPoolUpdater. | ||
| func newLoadBalancerBackendPoolUpdater(az *Cloud, interval time.Duration) *loadBalancerBackendPoolUpdater { |
There was a problem hiding this comment.
Could you add two new configurations for the batch updater intervals (LB and route)? we may need to tune the intervals from time to time (this could be done in a following PR).
k8s-ci-robot
added
the
lgtm
|
/easycla |
k8s-ci-robot
added
the
cncf-cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind bug
What this PR does / why we need it:
feat: add load balancer backend pool batch updater
fix a bug that the route updater and zone fetcher will not be exited every time the service reconciler restarts.
Which issue(s) this PR fixes:
Fixes #
Related: #4013
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: