Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.26] fix: truncate pls frontendIPConfig name if it's too long #4540

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #4537

/assign jwtty

Fix privateLinkService creation failure in case customer's subnet name or privateLinkService name is too long.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Aug 31, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2023
@jwtty
Copy link
Member

jwtty commented Sep 1, 2023

/kind bug
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind labels Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@jwtty
Copy link
Member

jwtty commented Sep 1, 2023

/retest pull-cloud-provider-azure-check-1-26

@k8s-ci-robot
Copy link
Contributor

@jwtty: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-cloud-provider-azure-check-1-26
  • /test pull-cloud-provider-azure-e2e-capz-1-26
  • /test pull-cloud-provider-azure-e2e-ccm-capz-1-26
  • /test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-26
  • /test pull-cloud-provider-azure-unit-1-26

Use /test all to run all jobs.

In response to this:

/retest pull-cloud-provider-azure-check-1-26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jwtty
Copy link
Member

jwtty commented Sep 1, 2023

/test pull-cloud-provider-azure-check-1-26

@k8s-ci-robot k8s-ci-robot merged commit 466b49c into kubernetes-sigs:release-1.26 Sep 1, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants