Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip tagging route table that is not in the cluster resource group #4715

Merged
merged 1 commit into from Oct 12, 2023
Merged

fix: skip tagging route table that is not in the cluster resource group #4715

merged 1 commit into from Oct 12, 2023

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Oct 5, 2023 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: skip tagging route table that is not in the cluster resource group.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: skip tagging route table that is not in the cluster resource group.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@nilo19 nilo19 requested a review from feiskyer October 5, 2023 02:47
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2023
feiskyer
feiskyer reviewed Oct 7, 2023
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but could you update the PR title and release notes?

@nilo19 nilo19 changed the title feat: add a configuration SkipTaggingRouteTable to skip tagging the… fix: skip tagging route table that is not in the cluster resource group Oct 7, 2023
@nilo19 nilo19 added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2023
@nilo19
Copy link
Contributor Author

nilo19 commented Oct 7, 2023

Changes LGTM, but could you update the PR title and release notes?

Updated.

feiskyer
feiskyer reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@nilo19
Copy link
Contributor Author

nilo19 commented Oct 12, 2023

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 12, 2023 •
edited

@nilo19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-capz bbc23a7 link unknown /test pull-cloud-provider-azure-e2e-ccm-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 01d7fa5 into kubernetes-sigs:master Oct 12, 2023
14 of 17 checks passed
@nilo19 nilo19 deleted the feat/skip-tag-rt branch October 13, 2023 00:13
@nilo19
Copy link
Contributor Author

nilo19 commented Oct 13, 2023

/cherrypick release-1.25

@k8s-infra-cherrypick-robot
Copy link

@nilo19: new pull request created: #4791

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 13, 2023
Merged
@nilo19
Copy link
Contributor Author

nilo19 commented Oct 13, 2023

/cherrypick release-1.26

@nilo19
Copy link
Contributor Author

nilo19 commented Oct 13, 2023

/cherrypick release-1.27

@nilo19
Copy link
Contributor Author

nilo19 commented Oct 13, 2023

/cherrypick release-1.28

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 13, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@nilo19: new pull request created: #4792

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 13, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@nilo19: new pull request created: #4793

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 13, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@nilo19: new pull request created: #4794

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@jwtty jwtty Awaiting requested review from jwtty

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilo19 @k8s-ci-robot @k8s-infra-cherrypick-robot @feiskyer