fix: refresh the load balancer object after updating backend pools to…

[nilo19]

… prevent etag mismatch error

What type of PR is this?

/kind bug

What this PR does / why we need it:

We used to refresh the LB object after updating the backend pools inside the function ReconcileBackendPools, but the new LB object is not read by the code outside of the function. In this case, the etag of the LB will be outdated and cause HTTP 412 error. This PR ensures the LB is updated after any changes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: refresh the load balancer object after updating backend pools to prevent etag mismatch error

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nilo19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nilo19]

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

[feiskyer]

Looks good

/lgtm

[nilo19]

/retest

[nilo19]

/cherrypick release-1.28

[k8s-infra-cherrypick-robot]

@nilo19: new pull request created: #4853

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nilo19]

/cherrypick release-1.27

[k8s-infra-cherrypick-robot]

@nilo19: #4839 failed to apply on top of branch "release-1.27":

Applying: fix: refresh the load balancer object after updating backend pools to prevent etag mismatch error
Using index info to reconstruct a base tree...
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_backendpool.go
M	pkg/provider/azure_loadbalancer_backendpool_test.go
M	pkg/provider/azure_loadbalancer_test.go
M	pkg/provider/azure_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_test.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer_backendpool_test.go
Auto-merging pkg/provider/azure_loadbalancer_backendpool.go
Auto-merging pkg/provider/azure_loadbalancer.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: refresh the load balancer object after updating backend pools to prevent etag mismatch error
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feiskyer]

@nilo19 cherry-picks need to be done manually