fix: VM name should be obtained from NIC.VirtualMachine.ID instead of…

[nilo19]

… NIC name.

What type of PR is this?

/kind bug

What this PR does / why we need it:

The VM name cannot be derived from NIC name when using standalone VMs. We need to obtain it from NIC.VirtualMachine.ID.

Which issue(s) this PR fixes:

Fixes #4823

Special notes for your reviewer:

This will introduce an extra ARM call.

Does this PR introduce a user-facing change?

fix: VM name should be obtained from NIC.VirtualMachine.ID instead of NIC name.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nilo19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nilo19]

/retest

[nilo19]

/retest

[nilo19]

/retest

[feiskyer]

/lgtm

[nilo19]

/cherrypick release-1.28

[k8s-infra-cherrypick-robot]

@nilo19: new pull request created: #4878

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nilo19]

/cherrypick release-1.28

[k8s-infra-cherrypick-robot]

@nilo19: new pull request could not be created: failed to create pull request against kubernetes-sigs/cloud-provider-azure#release-1.28 from head k8s-infra-cherrypick-robot:cherry-pick-4848-to-release-1.28: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-4848-to-release-1.28."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nilo19]

/cherrypick release-1.27

[k8s-infra-cherrypick-robot]

@nilo19: #4848 failed to apply on top of branch "release-1.27":

Applying: fix: VM name should be obtained from NIC.VirtualMachine.ID instead of NIC name.
Using index info to reconstruct a base tree...
M	pkg/provider/azure_utils.go
M	pkg/provider/azure_vmss_cache.go
M	pkg/provider/azure_vmss_cache_test.go
M	pkg/provider/azure_vmssflex.go
M	pkg/provider/azure_vmssflex_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_vmssflex_test.go
Auto-merging pkg/provider/azure_vmssflex.go
Auto-merging pkg/provider/azure_vmss_cache_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_vmss_cache_test.go
Auto-merging pkg/provider/azure_vmss_cache.go
Auto-merging pkg/provider/azure_utils.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: VM name should be obtained from NIC.VirtualMachine.ID instead of NIC name.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.