New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry picks of #4891 and #5042 against release-1.28 #5157
Cherry picks of #4891 and #5042 against release-1.28 #5157
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…sterServiceLoadBalancerHealthProbeMode` to `shared`, all cluster services will share one health probe targeting the kube-proxy port 10256 and /healthz by default. The health check port and path can be configured by `clusterServiceSharedLoadBalancerHealthProbePort` and `clusterServiceSharedLoadBalancerHealthProbePort`. (cherry picked from commit 2e4de2f)
…sing it when deleting a service (cherry picked from commit 686764f)
3d7b654
to
8e5c27a
Compare
/retest |
ad5c031
to
c6167d0
Compare
/retest |
/test pull-cloud-provider-azure-e2e-capz-1-28 |
/lgtm |
@nilo19: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
#4891: Support shared load balancer health probe mode. By setting
clusterServiceLoadBalancerHealthProbeMode
toshared
, all cluster services will share one health probe targeting the kube-proxy port 10256 and /healthz by default. The health check port and path can be configured byclusterServiceSharedLoadBalancerHealthProbePort
andclusterServiceSharedLoadBalancerHealthProbePort
.#5042: We remove the health probe related to the service when we delete the service, and this includes removing the shared health probe. But the shared probe should not be removed if there are other services using it. This PR checks if there are other services referencing the shared probe before removing it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: