Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picks of #4891 and #5042 against release-1.28 #5157

Merged

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Dec 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

#4891: Support shared load balancer health probe mode. By setting clusterServiceLoadBalancerHealthProbeMode to shared, all cluster services will share one health probe targeting the kube-proxy port 10256 and /healthz by default. The health check port and path can be configured by clusterServiceSharedLoadBalancerHealthProbePort and clusterServiceSharedLoadBalancerHealthProbePort.

#5042: We remove the health probe related to the service when we delete the service, and this includes removing the shared health probe. But the shared probe should not be removed if there are other services using it. This PR checks if there are other services referencing the shared probe before removing it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

feat: support shared load balancer health probe mode. By setting `clusterServiceLoadBalancerHealthProbeMode` to `shared`, all cluster services will share one health probe targeting the kube-proxy port 10256 and /healthz by default. The health check port and path can be configured by `clusterServiceSharedLoadBalancerHealthProbePort` and `clusterServiceSharedLoadBalancerHealthProbePort`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2023
…sterServiceLoadBalancerHealthProbeMode` to `shared`, all cluster services will share one health probe targeting the kube-proxy port 10256 and /healthz by default. The health check port and path can be configured by `clusterServiceSharedLoadBalancerHealthProbePort` and `clusterServiceSharedLoadBalancerHealthProbePort`.

(cherry picked from commit 2e4de2f)
…sing it when deleting a service

(cherry picked from commit 686764f)
@nilo19 nilo19 force-pushed the feat/cherry-pick-shared-probe branch from 3d7b654 to 8e5c27a Compare January 7, 2024 02:24
@nilo19
Copy link
Contributor Author

nilo19 commented Jan 7, 2024

/retest

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2024
@nilo19 nilo19 force-pushed the feat/cherry-pick-shared-probe branch from ad5c031 to c6167d0 Compare January 8, 2024 04:43
@nilo19
Copy link
Contributor Author

nilo19 commented Jan 9, 2024

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Jan 9, 2024

/test pull-cloud-provider-azure-e2e-capz-1-28

@jwtty
Copy link
Member

jwtty commented Jan 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2024
@nilo19 nilo19 merged commit 3032473 into kubernetes-sigs:release-1.28 Jan 9, 2024
15 checks passed
@nilo19 nilo19 deleted the feat/cherry-pick-shared-probe branch January 9, 2024 05:03
@k8s-ci-robot
Copy link
Contributor

@nilo19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-28 c6167d0 link unknown /test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-28

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants