fix: [multi-slb] Put the service in the load balancer that has no lab…

[nilo19]

…el/namespace selector only if there is no other choice for the service.

What type of PR is this?

/kind bug

What this PR does / why we need it:

For a load balancer with no label/namespace selectors:
current behavior: it can be a placement targets for services.
new behavior: it can be a placement target for a service if and only if there is no other choice for the service.
Ref: #5261

Which issue(s) this PR fixes:

Fixes #5261

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: [multi-slb] Put the service in the load balancer that has no label/namespace selector only if there is no other choice for the service.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nilo19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

/lgtm

thanks for the fixes!

[feiskyer]

please validate manually as well and unhold after that.

/hold

[nilo19]

/hold cancel

[nilo19]

We need to ignore the -internal suffix when comparing lb names, or we will ignore all of the internal lbs here.

[nilo19]

@desek this would fix the issue. Please take a look.

[feiskyer]

/lgtm

[nilo19]

/cherrypick release-1.28

[k8s-infra-cherrypick-robot]

@nilo19: #5281 failed to apply on top of branch "release-1.28":

Applying: fix: [multi-slb] Put the service in the load balancer that has no label/namespace selector only if there is no other choice for the service.
Using index info to reconstruct a base tree...
M	hack/deploy-cluster-capz.sh
M	pkg/provider/azure.go
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_repo.go
M	pkg/provider/azure_loadbalancer_test.go
M	pkg/provider/azure_standard.go
M	pkg/provider/azure_utils.go
M	tests/e2e/network/multiple_standard_lb.go
M	tests/k8s-azure/manifest/cluster-api/vmss-multi-nodepool.yaml
Falling back to patching base and 3-way merge...
Auto-merging tests/k8s-azure/manifest/cluster-api/vmss-multi-nodepool.yaml
CONFLICT (content): Merge conflict in tests/k8s-azure/manifest/cluster-api/vmss-multi-nodepool.yaml
Auto-merging tests/e2e/network/multiple_standard_lb.go
CONFLICT (content): Merge conflict in tests/e2e/network/multiple_standard_lb.go
Auto-merging pkg/provider/azure_utils.go
Auto-merging pkg/provider/azure_standard.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer_repo.go
Auto-merging pkg/provider/azure_loadbalancer.go
Auto-merging pkg/provider/azure.go
Auto-merging hack/deploy-cluster-capz.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: [multi-slb] Put the service in the load balancer that has no label/namespace selector only if there is no other choice for the service.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.