fix: Skip attaching/detaching vmss vm to lb backend pool if the vm is… #5356
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -113,8 +113,8 @@ const ( | |||
| // StrRawVersion is the raw version string | |||
| StrRawVersion string = "raw" | |||
|
|
|||
| // VirtualMachineScaleSetsDeallocating indicates VMSS instances are in Deallocating state. | |||
| VirtualMachineScaleSetsDeallocating = "Deallocating" | |||
There was a problem hiding this comment.
This is wrong because the Deallocating is powerstate instead of provisioning state. The correct state is Deleting.
nilo19
force-pushed
the
fix/deleted-vmss
branch
2 times, most recently
from
dc508b1
to
5c77f20
Compare
… not active. We should not update the VM instance if its provisioning state or power state is not good. This will save a lot of api calls and reduce throttling issues.
nilo19
force-pushed
the
fix/deleted-vmss
branch
from
5c77f20
to
3bc5733
Compare
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/cherrypick release-1.29 |
|
@nilo19: new pull request created: #5361 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-1.29 |
|
@lzhecheng: new pull request created: #5365 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… not active.
We should not update the VM instance if its provisioning state or power state is not good. This will save a lot of api calls and reduce throttling issues.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: Skip attaching/detaching vmss vm to lb backend pool if the vm is not active.
We should not update the VM instance if its provisioning state or power state is not good. This will save a lot of api calls and reduce throttling issues.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: