Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating NSG rule when access control enabled with IPv6 single stack #5367

Conversation

zarvd
Copy link
Contributor

@zarvd zarvd commented Feb 4, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #5366

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix creating NSG rule when access control enabled with IPv6 single stack

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @lodrem. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lodrem
Once this PR has been reviewed and has the lgtm label, please assign lzhecheng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 4, 2024
@feiskyer
Copy link
Member

feiskyer commented Feb 4, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2024
@zarvd zarvd force-pushed the loadbalancer/fix-ipv6-single-stack branch from 28f0bec to e49c308 Compare February 4, 2024 07:48
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2024
@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26
/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-26

@zarvd
Copy link
Contributor Author

zarvd commented Feb 4, 2024

/retest

@zarvd
Copy link
Contributor Author

zarvd commented Feb 4, 2024

@lzhecheng Looks like these two IPv6 jobs aren’t configured properly.

@lzhecheng
Copy link
Contributor

/retest

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26

@zarvd
Copy link
Contributor Author

zarvd commented Feb 5, 2024

/retest

@zarvd
Copy link
Contributor Author

zarvd commented Feb 5, 2024

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26

@zarvd
Copy link
Contributor Author

zarvd commented Feb 5, 2024

/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-26

1 similar comment
@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-26

@zarvd
Copy link
Contributor Author

zarvd commented Feb 5, 2024

The CI pipeline for IPv6 is quite unstable and keeps failing, but it worked fine on my local standalone env.

@lzhecheng
Copy link
Contributor

/retest

@lzhecheng
Copy link
Contributor

The failures are not related to the change. I will handle the e2e issue in this PR

@k8s-ci-robot
Copy link
Contributor

@lodrem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26 e49c308 link true /test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26
pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-26 e49c308 link true /test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-26

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lzhecheng lzhecheng merged commit ccc3c00 into kubernetes-sigs:release-1.26 Feb 6, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants