New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creating NSG rule when access control enabled with IPv6 single stack #5367
Fix creating NSG rule when access control enabled with IPv6 single stack #5367
Conversation
Hi @lodrem. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lodrem The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
28f0bec
to
e49c308
Compare
/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26 |
/retest |
@lzhecheng Looks like these two IPv6 jobs aren’t configured properly. |
/retest |
/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26 |
/retest |
/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-26 |
/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-26 |
1 similar comment
/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-26 |
The CI pipeline for IPv6 is quite unstable and keeps failing, but it worked fine on my local standalone env. |
/retest |
The failures are not related to the change. I will handle the e2e issue in this PR |
@lodrem: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ccc3c00
into
kubernetes-sigs:release-1.26
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5366
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: