Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.28] fix: allow space separated load balancer source ranges #5893

Merged
merged 1 commit into from Apr 10, 2024
Merged

[release-1.28] fix: allow space separated load balancer source ranges #5893

merged 1 commit into from Apr 10, 2024

Conversation

jwtty
Copy link
Member

@jwtty jwtty commented Apr 10, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

cherry-pick #5885

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow space-separated load balancer source ranges in service annotation. Allow `service.beta.kubernetes.io/load-balancer-source-ranges` to be used together with `service.beta.kubernetes.io/azure-allowed-service-tags`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2024
@jwtty jwtty changed the title allow space separated load balancer source ranges [release-1.28] fix: allow space separated load balancer source ranges Apr 10, 2024
@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2024
@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-28
/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-28
/test pull-cloud-provider-azure-e2e-ccm-dualstack-vmss-capz-1-28
/test pull-cloud-provider-azure-e2e-ccm-dualstack-capz-1-28

@jwtty
Copy link
Member Author

jwtty commented Apr 10, 2024

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz-1-28

@jwtty
Copy link
Member Author

jwtty commented Apr 10, 2024

/test pull-cloud-provider-azure-e2e-ccm-ipv6-vmss-capz-1-28

@k8s-ci-robot k8s-ci-robot merged commit 7f4749a into kubernetes-sigs:release-1.28 Apr 10, 2024
19 checks passed
@jwtty jwtty deleted the cp-range-1.28 branch April 10, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@lzhecheng lzhecheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwtty @k8s-ci-robot @lzhecheng