✨ Implement e2e integration testing by using CAPI v1.6 test framework #147
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jont828 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Jont828
force-pushed
the
capi-test-framework
branch
7 times, most recently
from
875c7f6
to
9e562c1
Compare
Jont828
force-pushed
the
capi-test-framework
branch
2 times, most recently
from
cb25512
to
7c056bc
Compare
There was a problem hiding this comment.
Good work @Jont828 ! Just have some minor nits.
I was able to successfully run the the test locally (Mac OS).
❯ ./scripts/ci-e2e.sh
.
.
Ran 1 of 1 Specs in 411.121 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
Ginkgo ran 1 suite in 7m14.369243292s
Test Suite Passed
Do we know if the tests are running good on Linux ?
Jont828
force-pushed
the
capi-test-framework
branch
from
44a663b
to
35350a7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| -e2e.skip-resource-cleanup=$(SKIP_RESOURCE_CLEANUP) -e2e.use-existing-cluster=$(USE_EXISTING_CLUSTER) | ||
|
|
||
| .PHONY: test-e2e-run | ||
| test-e2e-run: |
There was a problem hiding this comment.
Could you add a make help comment here? And maybe clarify the one above for test-e2e-run-skip-manifest?
| $(MAKE) test-e2e-run-skip-manifest | ||
|
|
||
| .PHONY: get-e2e-kubeconfig | ||
| get-e2e-kubeconfig: |
There was a problem hiding this comment.
Could you add a make help comment here?
| @@ -1,6 +1,6 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Copyright 2018 The Kubernetes Authors. | |||
| # Copyright 2024 The Kubernetes Authors. | |||
There was a problem hiding this comment.
I'm not a lawyer, but in general I don't think we should update the copyright assertion date in existing files, just use the current year when new files are added. (The dates don't have to agree between different files in the project.)
| cni: calico | ||
| repoURL: https://docs.tigera.io/calico/charts | ||
| chartName: tigera-operator | ||
| # version: ${CALICO_VERSION} |
There was a problem hiding this comment.
Is this a comment or commented-out code?
| RepositoryFolder: repositoryFolder, | ||
| } | ||
|
|
||
| // // Ensuring a CNI file is defined in the config and register a FileTransformation to inject the referenced file as in place of the CNI_RESOURCES envSubst variable. |
There was a problem hiding this comment.
Commented-out code here should be deleted IMHO.
| // kubetestConfigFilePath is the path to the kubetest configuration file | ||
| kubetestConfigFilePath string | ||
|
|
||
| // kubetestRepoListPath |
There was a problem hiding this comment.
Could you flesh out the comment here?
|
D'oh, I was too late. No worries, my comments were mostly cosmetic; I'll follow up with a PR to address them. Edit: see #161. |
What this PR does / why we need it: Finally got around to adding e2e testing. This will substantially improve the contributor process by providing a confident signal on whether or not a PR breaks anything in the e2e scenario.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #149