Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CAPI e2e test job for CAAPH #31726

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add CAPI e2e test job for CAAPH #31726

merged 1 commit into from
Jan 31, 2024
+65 −0

Conversation

Jont828
Copy link
Contributor

@Jont828 Jont828 commented Jan 25, 2024

Hold until this PR merges.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 25, 2024
@Jont828 Jont828 force-pushed the caaph-e2e-jobs branch 2 times, most recently from d109065 to 3c73ed7 Compare January 25, 2024 23:08
mboersma
mboersma approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold until kubernetes-sigs/cluster-api-addon-provider-helm#147 merges.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jont828
Copy link
Contributor Author

Jont828 commented Jan 31, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 27428bc into kubernetes:master Jan 31, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Jont828: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-addon-provider-helm-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-addon-provider-helm/cluster-api-addon-provider-helm-periodics-main.yaml
  • key cluster-api-addon-provider-helm-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-addon-provider-helm/cluster-api-addon-provider-helm-presubmits-main.yaml

In response to this:

Hold until this PR merges.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@rjsadow rjsadow Awaiting requested review from rjsadow

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jont828 @k8s-ci-robot @mboersma