This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
⚠️ Adds encoding field for cloud-init files #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
chuckha
commented
Sep 3, 2019
| description: Encoding specifies the encoding of the file | ||
| contents. | ||
| enum: | ||
| - b64 |
There was a problem hiding this comment.
This looks like yaml is going to interpolate this as binary or something O_O
|
/hold i want to add at least one test to the cloud init module 😔 |
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Chuck Ha <chuckh@vmware.com>
k8s-ci-robot
added
size/L
|
/hold cancel ready for review. |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/hold changing constants |
k8s-ci-robot
added
do-not-merge/hold
Signed-off-by: Chuck Ha <chuckh@vmware.com>
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
This PR adds an Encoding type for the cloud init files.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #202
/assign @detiber