-
Notifications
You must be signed in to change notification settings - Fork 67
⚠️ Adds encoding field for cloud-init files #204
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
description: Encoding specifies the encoding of the file | ||
contents. | ||
enum: | ||
- b64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like yaml is going to interpolate this as binary or something O_O
/hold i want to add at least one test to the cloud init module 😔 |
Signed-off-by: Chuck Ha <chuckh@vmware.com>
/hold cancel ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold changing constants |
Signed-off-by: Chuck Ha <chuckh@vmware.com>
/hold cancel |
/lgtm |
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
This PR adds an Encoding type for the cloud init files.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #202
/assign @detiber