Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: Modify Makefile to just call bazel #292

Closed
timothysc opened this issue Oct 22, 2018 · 6 comments
Closed

RFE: Modify Makefile to just call bazel #292

timothysc opened this issue Oct 22, 2018 · 6 comments
Assignees
@randomvariable @liztio
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
20181108

Comments

@timothysc
Copy link
Member

Describe the solution you'd like
Modify the Makefile to reduce the number of targets and to have a .PHONY precondition, requiring that developer install bazel with a link to the simplified instructions.

This is standard operating procedure, for many build systems as they migrate. e.g. It's normal to add a make deps that outlines the dependencies needed.

https://suva.sh/posts/well-documented-makefiles/

/kind feature
/assign @liztio
/cc @randomvariable
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 22, 2018
@randomvariable
Copy link
Member

i'm going to change #290 into tackling this as having a consistent Go toolchain is needed to be able to get consistent results with go fmt because parameter alignment preferences changed.

@randomvariable
Copy link
Member

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 23, 2018
@detiber detiber added this to the 20181025 milestone Oct 23, 2018
@randomvariable randomvariable mentioned this issue Oct 24, 2018
Merged
@detiber detiber modified the milestones: 20181025, 20181108 Oct 26, 2018
@detiber
Copy link
Member

detiber commented Oct 26, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Oct 26, 2018
@randomvariable
Copy link
Member

randomvariable commented Oct 29, 2018 •
edited
Loading

resolved in #290

/close

@randomvariable
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randomvariable randomvariable

@liztio liztio

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
20181108
Development

No branches or pull requests
5 participants
@timothysc @detiber @randomvariable @k8s-ci-robot @liztio