-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Make example controlplane HA, add toleration to managers #1061
✨ Make example controlplane HA, add toleration to managers #1061
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b714c54
to
04ab324
Compare
Signed-off-by: Vince Prignano <vincepri@vmware.com>
04ab324
to
aff0474
Compare
/lgtm |
joinConfiguration: | ||
controlPlane: | ||
advertiseAddress: '{{ ds.meta_data.local_ipv4 }}' | ||
bindPort: 6443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The advertiseAddress and bindPort should not be needed here.
joinConfiguration: | ||
controlPlane: | ||
advertiseAddress: '{{ ds.meta_data.local_ipv4 }}' | ||
bindPort: 6443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The advertiseAddress and bindPort should not be needed here.
name: ${CLUSTER_NAME}-controlplane-1 | ||
spec: | ||
instanceType: ${CONTROL_PLANE_MACHINE_TYPE} | ||
iamInstanceProfile: "control-plane.cluster-api-provider-aws.sigs.k8s.io" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To support pivoting, all of these will need to be updated with the controllers.cluster-api-provider-aws.sigs.k8s.io
role
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Release note: