Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Support Tilt for local development #1432

Merged
merged 1 commit into from
Dec 17, 2019
Merged

✨ Support Tilt for local development #1432

merged 1 commit into from
Dec 17, 2019

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Dec 17, 2019 •
edited

What this PR does / why we need it:

Support Tilt for local development. Requires kubernetes-sigs/cluster-api#1894.

Replaces #1422

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@ncdc
Support Tilt for local development
0b37715 
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
@ncdc ncdc added this to the v0.5.0 milestone Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2019
@ncdc ncdc mentioned this pull request Dec 17, 2019
Closed
chuckha
chuckha approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, it's nice and straightforward.

vincepri
vincepri approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3344c09 into kubernetes-sigs:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckha chuckha chuckha approved these changes

@vincepri vincepri vincepri approved these changes

@detiber detiber Awaiting requested review from detiber

@sethp-nr sethp-nr Awaiting requested review from sethp-nr

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ncdc @k8s-ci-robot @chuckha @vincepri