Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add tilt-based development tooling #1894

Merged
merged 1 commit into from
Dec 17, 2019
Merged

✨ Add tilt-based development tooling #1894

merged 1 commit into from
Dec 17, 2019

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Dec 13, 2019

What this PR does / why we need it:
Add tilt-based development tooling to simplify rapid iterative development.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Dec 13, 2019

This is rough around the edges & I still need to test a few scenarios, but I wanted to post for 👀

@ncdc
Copy link
Contributor Author

ncdc commented Dec 13, 2019

Also, I noticed after I added the new tilt.md file that we have a developer's guide, so I'll need to reconcile before merging.

@ncdc
Copy link
Contributor Author

ncdc commented Dec 13, 2019

Also note, if you want to use this with CAPA, it requires a corresponding CAPA PR that I haven't opened yet. Will do soon.

@ncdc
Copy link
Contributor Author

ncdc commented Dec 13, 2019

@chuckha this isn't 100% ready for review, but if you wanted to see what I've been working on...

@detiber
Copy link
Member

detiber commented Dec 13, 2019

@ncdc what if only the capi (and capd, since it's in repo) config was in the Tiltfile here, and we added an additional Tiltfile to the AWS provider as well? This would require running tilt multiple times (once for each provider), but wouldn't require configuration as to where the other repos are

@ncdc
Copy link
Contributor Author

ncdc commented Dec 13, 2019

I can pull the aws configuration and move it to capa (and have this tiltfile include it), but I'd still like to have a single primary tiltfile/tilt up.

@ncdc ncdc force-pushed the tilt branch 2 times, most recently from db73316 to 4f0961f Compare December 13, 2019 22:35
@ncdc ncdc mentioned this pull request Dec 13, 2019
Closed
@randomvariable
Copy link
Member

Yup, this approach looks like an evolution of what I got.

Including a provider Tiltfile works well enough I think, with the config saying which provider you're currently working with.

@ncdc ncdc changed the title [WIP] ✨ Add tilt-based development tooling ✨ Add tilt-based development tooling Dec 16, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2019
vincepri
vincepri approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold
feel free to unhold if there are no other comments

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@ncdc ncdc changed the title ✨ Add tilt-based development tooling [WIP] ✨ Add tilt-based development tooling Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Dec 16, 2019

Re-enabling WIP as live update isn't working consistently - need to fix.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Dec 16, 2019

Fixed live updating (arg missing slash)

chuckha
chuckha approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, looks great.

Tiltfile Show resolved Hide resolved
@ncdc ncdc changed the title [WIP] ✨ Add tilt-based development tooling ✨ Add tilt-based development tooling Dec 17, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2019
@ncdc ncdc mentioned this pull request Dec 17, 2019
Merged
@ncdc
Add tilt-based development tooling
5a26b12 
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
@ncdc
Copy link
Contributor Author

ncdc commented Dec 17, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2019
vincepri
vincepri approved these changes Dec 17, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@randomvariable
Copy link
Member

Tested on Linux
/lgtm

@rudoi
Copy link
Contributor

rudoi commented Dec 17, 2019

tested on macOS

/lgtm

@vincepri
Copy link
Member

/test pull-cluster-api-integration

@k8s-ci-robot k8s-ci-robot merged commit 546d56b into kubernetes-sigs:master Dec 17, 2019
@ncdc ncdc deleted the tilt branch October 1, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomvariable randomvariable randomvariable left review comments

@chuckha chuckha chuckha approved these changes

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@moshloop moshloop Awaiting requested review from moshloop

Assignees

@randomvariable randomvariable

@vincepri vincepri

@rudoi rudoi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ncdc @k8s-ci-robot @detiber @randomvariable @rudoi @vincepri @chuckha