Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.7] fix: added may resync check for EKS #2856

Merged
merged 1 commit into from
Oct 18, 2021
Merged

[release-0.7] fix: added may resync check for EKS #2856

merged 1 commit into from
Oct 18, 2021

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2846

/assign randomvariable

Reinstating the check for the maximum allowed resync period when EKS is enabled.

@richardcase
fix: added may resync check for EKS
1503b60 
When EKS was graduated the check to make sure that the
max sync time wasn't greater than 10 mins was missed.

Signed-off-by: Richard Case <richard@weave.works>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 18, 2021
Merged
1 task
@k8s-ci-robot k8s-ci-robot added this to the v0.7.x milestone Oct 18, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2021
@randomvariable
Copy link
Member

/triage accepted
/priority critical-urgent
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Oct 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@randomvariable randomvariable mentioned this pull request Oct 18, 2021
Closed
1 task
@k8s-ci-robot k8s-ci-robot merged commit 0fcf9d6 into kubernetes-sigs:release-0.7 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase Awaiting requested review from richardcase

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @randomvariable @k8s-ci-robot @richardcase