Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/golangci/golangci-lint from 1.45.2 to 1.47.2 in /hack/tools #3617

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Jul 25, 2022

What type of PR is this?
/area release

What this PR does / why we need it:
This PR does the following:

  • Bumps github.com/golangci/golangci-lint from 1.45.2 to 1.47.2 in /hack/tools.
  • Disable nonamedreturns, nosnakecase and exhaustruct linters.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jul 25, 2022
@k8s-ci-robot
Copy link
Contributor

@Ankitasw: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 25, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2022
@Ankitasw Ankitasw changed the title Bump github.com/golangci/golangci-lint from 1.45.2 to 1.47.2 in /hack/tools [WIP] Bump github.com/golangci/golangci-lint from 1.45.2 to 1.47.2 in /hack/tools Jul 25, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2022
@Ankitasw Ankitasw changed the title [WIP] Bump github.com/golangci/golangci-lint from 1.45.2 to 1.47.2 in /hack/tools Bump github.com/golangci/golangci-lint from 1.45.2 to 1.47.2 in /hack/tools Jul 26, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2022
@Ankitasw
Copy link
Member Author

This PR is ready for review/merge.

@sedefsavas
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit f5927f1 into kubernetes-sigs:main Jul 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.x milestone Jul 26, 2022
@sedefsavas
Copy link
Contributor

Let's see if this works with closed PRs.

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@sedefsavas: new pull request created: #3636

In response to this:

Let's see if this works with closed PRs.

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added a commit that referenced this pull request Jul 30, 2022
[release-1.5] Manual cherry pick of linter fixes (#3617 and #3623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants