-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix go1.19 linting errors #3623
Fix go1.19 linting errors #3623
Conversation
Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
@tobiasgiese: This issue is currently awaiting triage. If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I see that even the generated files needed to change, let's see if |
You are right, I have to replace the |
be75116
to
0574e83
Compare
/kind bug |
556d3e3
to
8ac7c1d
Compare
Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
8ac7c1d
to
f181d85
Compare
Why are we changing all the licence headers as part of this? |
I should've read the slack thread, doh. |
Thanks @tobiasgiese, I wish we'd followed the gofmt formatting rules earlier 🤣 From my side: /lgtm For approval: /assign sedefsavas |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.5 |
@sedefsavas: #3623 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
What this PR does / why we need it:
With kubernetes/test-infra#26920 our test image has been changed to go1.19-rc2. Therefore, we have to fix some linters and deprecations to make the linter happy again (analogues to kubernetes/kubernetes#111254).
Failed test as example: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3609/pull-cluster-api-provider-aws-test/1552246150055071744
Regarding the
ioutil
deprecation, please see go-critic/go-critic#1019Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Replaced all boilderplates with
Checklist:
Tobias Giese tobias.giese@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum