Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] fix: use v1beta1 version in EKS user kubeconfig #3763

Merged
merged 1 commit into from
Oct 31, 2022
Merged

[release-1.5] fix: use v1beta1 version in EKS user kubeconfig #3763

merged 1 commit into from
Oct 31, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #3740

/assign dlipovetsky

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Oct 7, 2022
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2022
@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2022
@dlipovetsky
Copy link
Contributor

Looking into the failure.

@dlipovetsky
Copy link
Contributor

dlipovetsky commented Oct 11, 2022 •
edited
Loading

There's a failure in the should create cluster with nested assumed role test. I see the same failure for an older backport PR, #3632.

I don't see any changes in this PR, or between release-1.5 and main, that appear to be related to the test failure.

I'll re-run the test.

@dlipovetsky
Copy link
Contributor

/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5

@dlipovetsky
Copy link
Contributor

A different test, "Should successfully create a cluster with machine pool machines" failed. It passed the first run.

I'll re-run again.

@dlipovetsky
Copy link
Contributor

/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5

@dlipovetsky
Copy link
Contributor

This PR only affects managed (EKS) clusters, but the failing tests in pull-cluster-api-provider-aws-e2e-blocking-release-1-5 have all been for an unmanaged cluster.

@dlipovetsky
Copy link
Contributor

/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5

@Skarlso
Copy link
Contributor

Skarlso commented Oct 17, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2022
@dlipovetsky
Copy link
Contributor

@sedefsavas I think this is worth merging into release-1.5

We can decide separately whether or not to release 1.5.1

@Ankitasw
Copy link
Member

/approve

@Skarlso
Copy link
Contributor

Skarlso commented Oct 26, 2022

/approve

This should now work, shouldn't it? 🤔

@dlipovetsky
Copy link
Contributor

dlipovetsky commented Oct 31, 2022 •
edited
Loading

It looks like the maintainer approval has no effect because the https://github.com/orgs/kubernetes-sigs/teams/cluster-api-provider-aws-maintainers is not up to date. I'll raise this on slack.

Update: We'll be able to approve once we backport the maintainer metadata to release-1.5 (#3807)

@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitasw, richardcase, Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit 299d2b7 into kubernetes-sigs:release-1.5 Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@sedefsavas sedefsavas Awaiting requested review from sedefsavas

Assignees

@Skarlso Skarlso

@dlipovetsky dlipovetsky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@k8s-infra-cherrypick-robot @dlipovetsky @Skarlso @Ankitasw @richardcase @k8s-ci-robot @dkoshkin