Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] fix: use v1beta1 version in EKS user kubeconfig #3763

Merged
merged 1 commit into from
Oct 31, 2022
Merged

[release-1.5] fix: use v1beta1 version in EKS user kubeconfig #3763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/cloud/services/eks/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,11 @@ func (s *Service) createUserKubeconfigSecret(ctx context.Context, cluster *eks.C
return fmt.Errorf("creating base kubeconfig: %w", err)
}

execConfig := &api.ExecConfig{APIVersion: "client.authentication.k8s.io/v1alpha1"}
// Version v1alpha1 was removed in Kubernetes v1.23.
// Version v1 was released in Kubernetes v1.23.
// Version v1beta1 was selected as it has the widest range of support
// This should be changed to v1 once EKS no longer supports Kubernetes <v1.23
execConfig := &api.ExecConfig{APIVersion: "client.authentication.k8s.io/v1beta1"}
switch s.scope.TokenMethod() {
case ekscontrolplanev1.EKSTokenMethodIAMAuthenticator:
execConfig.Command = "aws-iam-authenticator"
Expand Down