Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for windows worker nodes #153

Closed
awesomenix opened this issue Mar 26, 2019 · 25 comments · Fixed by #1036
Closed

Support for windows worker nodes #153

awesomenix opened this issue Mar 26, 2019 · 25 comments · Fixed by #1036
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. parity Used to track feature parity with other Azure provisioning tools (AKS, AKS Engine, etc) priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@awesomenix
Copy link
Contributor

/kind feature

Since kubernetes 1.14 just GA windows worker nodes, add support for the same in cluster api

Describe the solution you'd like

  1. VM Extension service needs to be refactored to handle CSE in Microsoft.Compute namespace
  2. Change default CNI to use Flannel, which has windows support (part of addons)
  3. Change VM Startup scripts to include support for windows, following guide here https://github.com/Azure/aks-engine/blob/1242dcc6fa5f7a55c685eb94fd82d8f668e90965/parts/k8s/kuberneteswindowssetup.ps1

Anything else you would like to add:
aks-engine has successful implementation, following the process would help implementing it here.

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 26, 2019
@justaugustus
Copy link
Member

justaugustus commented Mar 28, 2019

Currently blocked on adding support for Kubernetes 1.14: #154
I'm fine with this, but the CNI needs to be configurable. Default to weave for most cases, but use flannel, if you need to support Windows.

/priority important-longterm
/milestone next

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 28, 2019
@k8s-ci-robot k8s-ci-robot added this to the next milestone Mar 28, 2019
@justaugustus
Copy link
Member

Added Canal (flannel + Calico policy) as CNI in #181.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 12, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 11, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[DEPRECATED] Cluster API Azure (DO NOT USE) automation moved this from Backlog to Done (2019 - Q3) Sep 10, 2019
@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

/reopen
/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot reopened this Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[DEPRECATED] Cluster API Azure (DO NOT USE) automation moved this from Done (2019 - Q3) to In progress Oct 2, 2019
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 2, 2019
@justaugustus justaugustus moved this from In progress to Backlog in [DEPRECATED] Cluster API Azure (DO NOT USE) Oct 2, 2019
@justaugustus
Copy link
Member

Issue needs to updated to outline proposal for Windows support prior to implementation.
cc. @PatrickLang @marosset @ksubrmnn
/assign @marosset @CecileRobertMichon

@k8s-ci-robot
Copy link
Contributor

@justaugustus: GitHub didn't allow me to assign the following users: marosset.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Issue needs to updated to outline proposal for Windows support prior to implementation.
cc. @PatrickLang @marosset @ksubrmnn
/assign @marosset @CecileRobertMichon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

/assign @ksubrmnn
/unassign @CecileRobertMichon

@k8s-ci-robot
Copy link
Contributor

@justaugustus: GitHub didn't allow me to assign the following users: ksubrmnn.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ksubrmnn
/unassign @CecileRobertMichon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

/assign @ksubrmnn

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 22, 2020
[DEPRECATED] Cluster API Azure (DO NOT USE) automation moved this from Backlog to Done (2020 - Q1) Feb 22, 2020
Cluster API Azure automation moved this from Backlog to Done (2020 - Q1) Feb 22, 2020
@awesomenix awesomenix reopened this Feb 22, 2020
[DEPRECATED] Cluster API Azure (DO NOT USE) automation moved this from Done (2020 - Q1) to In progress Feb 22, 2020
Cluster API Azure automation moved this from Done (2020 - Q1) to In progress Feb 22, 2020
@CecileRobertMichon CecileRobertMichon removed this from In progress in Cluster API Azure Feb 24, 2020
@CecileRobertMichon CecileRobertMichon added this to Backlog in Cluster API Azure via automation Feb 24, 2020
@timothysc
Copy link
Member

@CecileRobertMichon - Is this targeted for any near-term milestone? If we can lend a hand here just let us know, I think it would be great to enable windows deployments.

cc @nader-ziada @yastij @ncdc

@ksubrmnn
Copy link
Contributor

ksubrmnn commented May 1, 2020

cc @JocelynBerrendonner

@k8s-ci-robot
Copy link
Contributor

@ksubrmnn: GitHub didn't allow me to assign the following users: JocelynBerrendonner.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/unassign @ksubrmnn
/assign @JocelynBerrendonner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksubrmnn
Copy link
Contributor

ksubrmnn commented May 1, 2020

/assign @ksubrmnn @marosset

@CecileRobertMichon CecileRobertMichon added the parity Used to track feature parity with other Azure provisioning tools (AKS, AKS Engine, etc) label Jun 4, 2020
@rbitia rbitia moved this from Backlog to To do in Cluster API Azure Jun 26, 2020
@CecileRobertMichon
Copy link
Contributor

Windows CAEP doc authored by @jsturtevant and @ksubrmnn is under review

@jsturtevant
Copy link
Contributor

/assign

@jsturtevant
Copy link
Contributor

jsturtevant commented Sep 24, 2020

The image support for Windows is in progress: kubernetes-sigs/image-builder#382

@CecileRobertMichon
Copy link
Contributor

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Nov 3, 2020
@CecileRobertMichon CecileRobertMichon modified the milestones: next, v0.4.11 Nov 12, 2020
Cluster API Azure automation moved this from To do to Done (2020 - Q2) Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. parity Used to track feature parity with other Azure provisioning tools (AKS, AKS Engine, etc) priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
No open projects
Cluster API Azure
  
Done (2020 - Q2)
9 participants