Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support via kubeadm #1036

Merged
merged 9 commits into from Jan 4, 2021
Merged

Windows support via kubeadm #1036

merged 9 commits into from Jan 4, 2021

Conversation

jsturtevant
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #153

Implements https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/proposals/20200804-windows-support.md

Special notes for your reviewer:
Uses an image from kubernetes-sigs/image-builder#382. This PR is close to merging and then this can go in.

Similar to #1035

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Add windows support

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 13, 2020
@jsturtevant jsturtevant mentioned this pull request Nov 13, 2020
Closed
3 tasks
@jsturtevant jsturtevant marked this pull request as draft November 14, 2020 00:37
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2020
@jsturtevant jsturtevant changed the title Windows support Windows support via kubeadm Nov 16, 2020
@CecileRobertMichon
Copy link
Contributor

is MachinePool VMSS support non-goal/future work?

@jsturtevant jsturtevant mentioned this pull request Nov 17, 2020
Merged
@jsturtevant jsturtevant force-pushed the windows-support branch 2 times, most recently from bd8b581 to 41be801 Compare November 17, 2020 21:41
@jsturtevant
Copy link
Contributor Author

I took a look and VMSS was pretty straight forward to add support.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2020
@devigned
Copy link
Contributor

/retest

@jsturtevant jsturtevant force-pushed the windows-support branch 3 times, most recently from c41fc67 to e6de58d Compare December 7, 2020 20:59
@jsturtevant
Copy link
Contributor Author

/retest

@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-verify

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2020
@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-windows

@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

1 similar comment
@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e

@jsturtevant
Copy link
Contributor Author

The e2e job failed for different set of tests each time

/test pull-cluster-api-provider-azure-e2e

@jsturtevant
Copy link
Contributor Author

The e2e job failed for different set of tests each time

created #1095 for further investigation

@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-windows

@jsturtevant
Copy link
Contributor Author

looks like there was a flake grabbing the kubectl version

mkdir -p /home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/hack/tools/bin
rm -f "/home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/hack/tools/bin/kubectl-v1.16.13*"
curl -fsL https://storage.googleapis.com/kubernetes-release/release/v1.16.13/bin/linux/amd64/kubectl -o /home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/hack/tools/bin/kubectl-v1.16.13
make[1]: *** [Makefile:250: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/hack/tools/bin/kubectl-v1.16.13] Error 56

I don't believe that is the correct version that is needed since our tests run 1.19.4. I will follow up with an issue/pr to fix that.

/test pull-cluster-api-provider-azure-e2e-windows

@jsturtevant jsturtevant mentioned this pull request Dec 22, 2020
Closed
3 tasks
@devigned
Copy link
Contributor

This PR looks great. I'd love to get it pulled in sooner than later, but I think we should hold off until after the holiday to make sure everyone gets a final review.

Awesome work, @jsturtevant!

cpanato
cpanato approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks for this! 🎉

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2020
@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Jan 4, 2021 •
edited 

~ k --kubeconfig ./kubeconfig get nodes -o wide
NAME                               STATUS   ROLES    AGE     VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                         KERNEL-VERSION     CONTAINER-RUNTIME
win-templ-lndvv                    Ready    <none>   3m31s   v1.19.4   10.1.0.5      <none>        Windows Server 2019 Datacenter   10.0.17763.1518    docker://19.3.12
win-templ-xk5fx                    Ready    <none>   2m58s   v1.19.4   10.1.0.7      <none>        Windows Server 2019 Datacenter   10.0.17763.1518    docker://19.3.12
win-template-control-plane-k5wgf   Ready    master   6m48s   v1.19.4   10.0.0.4      <none>        Ubuntu 18.04.5 LTS               5.4.0-1031-azure   containerd://1.4.1
win-template-md-0-456pg            Ready    <none>   4m32s   v1.19.4   10.1.0.4      <none>        Ubuntu 18.04.5 LTS               5.4.0-1031-azure   containerd://1.4.1
win-template-md-0-xfk4g            Ready    <none>   4m37s   v1.19.4   10.1.0.6      <none>        Ubuntu 18.04.5 LTS               5.4.0-1031-azure   containerd://1.4.1

Nice :)

/lgtm
/approve
🚢

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 20aef69 into kubernetes-sigs:master Jan 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4.11 milestone Jan 4, 2021
@jsturtevant jsturtevant mentioned this pull request Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@cpanato cpanato cpanato approved these changes

Assignees

@cpanato cpanato

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

Support for windows worker nodes
5 participants
@jsturtevant @CecileRobertMichon @devigned @cpanato @k8s-ci-robot