Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error when a SKU does not support AccelaratedNetworking #2979

Open
nawazkh opened this issue Jan 3, 2023 · 2 comments
Open

Log error when a SKU does not support AccelaratedNetworking #2979

nawazkh opened this issue Jan 3, 2023 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@nawazkh
Copy link
Member

nawazkh commented Jan 3, 2023

/kind bug

[Before submitting an issue, have you checked the Troubleshooting Guide?]

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

right now we just default to Azure and don't fail in the controller if a SKU that doesn't support AN has it explicitly enabled by the user.

What did you expect to happen:

  • User should be updated if the chosen SKU does not support AccelaratedNetworking.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version: v1.2.4
  • Kubernetes version: (use kubectl version): v1.25.2
  • OS (e.g. from /etc/os-release): na
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 3, 2023
@CecileRobertMichon
Copy link
Contributor

/help
/milestone next

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/milestone next

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the next milestone Jan 26, 2023
@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 26, 2023
@mboersma mboersma modified the milestones: next, v1.9 Mar 9, 2023
@jackfrancis jackfrancis modified the milestones: v1.9, next Apr 13, 2023
@jackfrancis jackfrancis removed this from the next milestone May 11, 2023
@nawazkh nawazkh changed the title Show error when a SKU does not support AccelaratedNetworking Log error when a SKU does not support AccelaratedNetworking Aug 3, 2023
@nawazkh nawazkh added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
Status: Todo
Development

No branches or pull requests

5 participants