✨ support accelerated networking

[mboersma]

What this PR does / why we need it:

Creates an acceleratedNetworking boolean in AzureMachineTemplate and in AzureMachinePool that enables Azure accelerated networking on the machine's network interface or on the VMSS, respectively.
If acceleratedNetworking is omitted from the provisioning template, it is enabled or disabled after an API call is made to determine if the requested SKU supports it.

Fixes #307

Special notes for your reviewer:

This could use more specific unit test coverage. I'm working on that, so maybe consider this a WIP.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

✨ support accelerated networking

[k8s-ci-robot]

Hi @mboersma. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[devigned]

/ok-to-test

[devigned]

Couple SDK related nits.

[nader-ziada]

@mboersma for the verify failure: since you added a field to the azuremachine spec, you have to generate the CRDs yaml files and include them in the commit

[mboersma]

you have to generate the CRDs yaml files

Actually the generated changes to config/crd/bases/exp.infrastructure.cluster.x-k8s.io_azuremachinepools.yaml as well as _azuremachines.yaml and _azuremachinetemplates.yaml were included in the first commit...

I'm not able to reproduce or fix the current CI failure. When I run make modules or make generate or ./hack/gen-flavors.sh I just get success and no file changes. I've used go 1.13.8 and 1.13.10 on macOS. Any ideas?

[devigned]

@mboersma try deleting ./hack/tools/bin, then make generate

[mboersma]

@devigned I tried that, but no diff. 😕

[nader-ziada]

I have had a similar problem before and what I did was removed the --quiet from this line in the Makefile https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/Makefile#L447 in a debugging commit to see what the error is

[mboersma]

removed the --quiet from this line in the Makefile...

Thanks @nader-ziada. I did something similar and it pointed to a missing comment in generated code that has been added. I think we are back on track now.

[mboersma]

/test pull-cluster-api-provider-azure-test

[CecileRobertMichon]

@mboersma is this ready for another review or should I wait? I think you mentioned having to add UTs for VMSS earlier in office hours

[mboersma]

@CecileRobertMichon there aren't any cases in vmss_test.go that test accelerated networking toggled on and off, specifically. Otherwise I think it's ready, but let me know if you see other test gaps or issues.

[CecileRobertMichon]

lgtm pending vmss test cases

[mboersma]

@CecileRobertMichon I added a vmss_test.go spec for accelerated networking on and off, then squashed and rebased.

[CecileRobertMichon]

/approve
/lgtm

Thanks @mboersma !

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment