Enable accelerated networking on VM sizes that support it

[CecileRobertMichon]

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
https://docs.microsoft.com/en-us/azure/virtual-network/create-vm-accelerated-networking-cli#supported-vm-instances

For VMs, enable using the EnableAcceleratedNetworking property of network interfaces
For VMSS, enable using the EnableAcceleratedNetworking property of scale sets

/good-first-issue

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• cluster-api-provider-azure version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[k8s-ci-robot]

@CecileRobertMichon:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
https://docs.microsoft.com/en-us/azure/virtual-network/create-vm-accelerated-networking-cli#supported-vm-instances

For VMs, enable using the EnableAcceleratedNetworking property of network interfaces
For VMSS, enable using the EnableAcceleratedNetworking property of scale sets

/good-first-issue

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• cluster-api-provider-azure version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[justaugustus]

/milestone v0.3

Ping @devigned to validate API responses for accelerated networking e.g., Azure/azure-sdk-for-go#5968

[justaugustus]

/assign @soggiest

[devigned]

Might be helpful to see how this is approached in aks-engine: Azure/aks-engine#1894

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[CecileRobertMichon]

keep open

[CecileRobertMichon]

@soggiest have you had time to look into this? If not I might give it a shot

[nader-ziada]

let me know if you need with this issue

[soggiest]

@CecileRobertMichon I haven't had any time to work on this, please go ahead and work on it

[CecileRobertMichon]

@mboersma is this something you'd be interested in helping out with?

[mboersma]

@CecileRobertMichon I would love to, with the caveat that I'm not yet familiar with the code. But please consider me assigned and I'll start on it this week.

[CecileRobertMichon]

Awesome, don't hesitate to lean on me as much as needed for onboarding with the code. Also I recommend starting here https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/docs/development.md.

/assign @mboersma

[justaugustus]

/remove-lifecycle stale

[CecileRobertMichon]

@mboersma are you still working on this?

[nader-ziada]

hey @mboersma , if you are not working on this, mind if I give it a try?
cc: @CecileRobertMichon

[mboersma]

@nader-ziada obviously I haven't gotten anywhere--please do, I don't want to impede progress.

[mboersma]

@nader-ziada I actually have this working now in a local branch. I'm adding some tests and will push a PR out soon.

[nader-ziada]

Thanks @mboersma