Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for resources and don't use envsubst in tilt #1294

Merged

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Apr 6, 2021

What type of PR is this?
/kind other

What this PR does / why we need it:
tilt fails on Linux with error: fork/exec /usr/bin/sh: argument list too long at

return str(local("echo \"{}\" | {}".format(yaml, envsubst_cmd), quiet=True))

This removes envsubst from that code path as it works without it via tilt settings. I wasn't able to work around it as I did with #829 because I couldn't figure out how to write to a file in tilt.

It also fixes and issue when the CRS's were pushed to the cluster before all the webhooks where setup.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 6, 2021
@jsturtevant jsturtevant changed the title ait for resources and don't use envsubst Wait for resources and don't use envsubst in tilt Apr 6, 2021
@nikhita
Copy link
Member

nikhita commented Apr 7, 2021

creating a (dummy) approve comment to re-trigger CI, the approval mechanism was broken for a bit - kubernetes/test-infra#21687

/approve

@nader-ziada
Copy link
Contributor

tilt-up worked for me on mac with the changes

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@nader-ziada
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-windows

@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-windows

That failure looks like the control plane didn't come online. The prior one looked like a timeout on the pod starting, which I can look into later.

@CecileRobertMichon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@CecileRobertMichon
Copy link
Contributor

./scripts/ci-e2e.sh: line 43: AZURE_SUBSCRIPTION_ID: Environment variable empty or not defined.

🤔 🤔

@CecileRobertMichon
Copy link
Contributor

/retest

@CecileRobertMichon
Copy link
Contributor

/retest

creds should be fixed now

@k8s-ci-robot k8s-ci-robot merged commit 3a8f70f into kubernetes-sigs:master Apr 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants