-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for resources and don't use envsubst in tilt #1294
Wait for resources and don't use envsubst in tilt #1294
Conversation
3764d46
to
b207e77
Compare
b207e77
to
0dc0540
Compare
creating a (dummy) approve comment to re-trigger CI, the approval mechanism was broken for a bit - kubernetes/test-infra#21687 /approve |
/lgtm |
/test pull-cluster-api-provider-azure-e2e-windows |
/test pull-cluster-api-provider-azure-e2e-windows That failure looks like the control plane didn't come online. The prior one looked like a timeout on the pod starting, which I can look into later. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, nikhita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🤔 🤔 |
/retest |
/retest creds should be fixed now |
What type of PR is this?
/kind other
What this PR does / why we need it:
tilt fails on Linux with
error: fork/exec /usr/bin/sh: argument list too long
atcluster-api-provider-azure/Tiltfile
Line 312 in 1c7ae8b
This removes envsubst from that code path as it works without it via tilt settings. I wasn't able to work around it as I did with #829 because I couldn't figure out how to write to a file in tilt.
It also fixes and issue when the CRS's were pushed to the cluster before all the webhooks where setup.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: