Developer Experience improvements #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
area/provider/azure
|
/priority critical-urgent |
k8s-ci-robot
added
priority/critical-urgent
k8s-ci-robot
added
size/L
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
soggiest
reviewed
Mar 11, 2019
Makefile
Outdated
|
|
||
| .PHONY: lint | ||
| lint: dep-ensure ## Lint codebase | ||
| @echo If you have generated new mocks, run make copy-genmocks before linting | ||
| @echo If you have genereated new mocks, run make copy-genmocks before linting |
There was a problem hiding this comment.
SUPER NIT
Generated is spelled wrong here
build/controller_gen.bzl
Outdated
| {controller_gen} all && \\ | ||
| cp -fR config $$GENDIR | ||
| {controller_gen} all && \\ | ||
| cp -fR config $$GENDIR |
There was a problem hiding this comment.
It looks like the spaces were removed before these lines. Was that on purpose?
tariq1890
reviewed
Mar 11, 2019
scripts/ci-bazel-integration.sh
Outdated
| @@ -0,0 +1,26 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Copyright 2018 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2018 The Kubernetes Authors. | |
| # Copyright 2019 The Kubernetes Authors. |
tariq1890
reviewed
Mar 11, 2019
docs/development.md
Outdated
| ### Get familiar with basic concepts | ||
|
|
||
| This provider is modeled after the upstream cluster-api project. To get familiar | ||
| with resources, concepts and conventions refer to the [upstream gitbook](https://kubernetes-sigs.github.io/cluster-api/). |
There was a problem hiding this comment.
SUPER DUPER NIT: can we rename it to cluster-api gitbook? Also let's move the link to the bottom of the readme.md for consistency's sake.
tariq1890
reviewed
Mar 13, 2019
docs/development.md
Outdated
| ### Get familiar with basic concepts | ||
|
|
||
| This provider is modeled after the upstream cluster-api project. To get familiar | ||
| with resources, concepts and conventions refer to the [upstream gitbook](https://kubernetes-sigs.github.io/cluster-api/). |
There was a problem hiding this comment.
Suggested change
| with resources, concepts and conventions refer to the [upstream gitbook](https://kubernetes-sigs.github.io/cluster-api/). | |
| with the concepts and conventions, refer to the [cluster-api gitbook](https://kubernetes-sigs.github.io/cluster-api/). |
k8s-ci-robot
added
size/XXL
justaugustus
force-pushed
the
dev
branch
4 times, most recently
from
158dd7e
to
eafd87c
Compare
justaugustus
force-pushed
the
dev
branch
2 times, most recently
from
70c2c23
to
8c40dec
Compare
tariq1890
reviewed
Mar 23, 2019
awesomenix
reviewed
Mar 23, 2019
| @@ -25,7 +25,7 @@ COPY vendor/ vendor/ | |||
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager sigs.k8s.io/cluster-api-provider-azure/cmd/manager | |||
|
|
|||
| # Copy the controller-manager into a thin image | |||
| FROM alpine:3.9 | |||
| FROM gcr.io/distroless/base | |||
There was a problem hiding this comment.
For reference to other reviewers
https://github.com/GoogleContainerTools/distroless/blob/master/base/README.md
justaugustus
force-pushed
the
dev
branch
7 times, most recently
from
6328c51
to
f58e84c
Compare
justaugustus
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Ready for review: |
|
overall looks good, let me know once the conflicts are resolved. |
- Update documentation - Update .gitignore - Remove skip_files in golangci config - Bump golang version (`1.12.1`) / switch thin image to `distroless/base` - Clean up Makefile - Bump bazel rules_go (`0.18.1`) - Bump kind version (`d4ff13e4808ee5a816ed92bf2d3348bda12413db`) - Rename build/asm_shim - Add bazel generator for kustomize - Update example specs - Update generate-yaml.sh - Update cmd packages - Add release tool - Regenerate CRDs Signed-off-by: Stephen Augustus <saugustus@vmware.com>
|
Thanks @awesomenix. Conflicts fixed up! |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awesomenix, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Augustus saugustus@vmware.com
What this PR does / why we need it:
Update developer toolbox and documentation:
1.12.1) / switch thin image todistroless/base0.18.1)d4ff13e4808ee5a816ed92bf2d3348bda12413db)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #127, fixes #108, fixes #98, fixes #107
Release note: