Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Update CCM and CNM templates to v0.7.4 #1378

Merged
merged 1 commit into from
May 17, 2021
Merged

[backport] Update CCM and CNM templates to v0.7.4 #1378

merged 1 commit into from
May 17, 2021

Conversation

CecileRobertMichon
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it: Updates cloud-controller-manager and cloud-node-manager default versions to v0.7.4 in the templates. v0.7.3 fixes a bug in the cache for VMs when using "vmss" vmType.

Note that #1323 cannot be cleanly cherry-picked as the OOT template has been refactored to use ClusterResourceSets since v0.4.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
solves #857 for out of tree cloud-provider

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update CCM and CNM templates to v0.7.4

@k8s-ci-robot k8s-ci-robot added this to the v0.4.15 milestone May 17, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2021
@CecileRobertMichon
Copy link
Contributor Author

/test ls

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-azure-test-release-0-4
  • /test pull-cluster-api-provider-azure-build-release-0-4
  • /test pull-cluster-api-provider-azure-e2e-release-0-4
  • /test pull-cluster-api-provider-azure-e2e-full-release-0-4
  • /test pull-cluster-api-provider-azure-e2e-windows-release-0-4
  • /test pull-cluster-api-provider-azure-capi-e2e-release-0-4
  • /test pull-cluster-api-provider-azure-verify-release-0-4
  • /test pull-cluster-api-provider-azure-conformance-v1alpha3-release-0-4
  • /test pull-cluster-api-provider-azure-conformance-v1alpha3-with-ci-artifacts-release-0-4
  • /test pull-cluster-api-provider-azure-apidiff-release-0-4

Use /test all to run the following jobs:

  • pull-cluster-api-provider-azure-test-release-0-4
  • pull-cluster-api-provider-azure-build-release-0-4
  • pull-cluster-api-provider-azure-e2e-release-0-4
  • pull-cluster-api-provider-azure-e2e-windows-release-0-4
  • pull-cluster-api-provider-azure-verify-release-0-4
  • pull-cluster-api-provider-azure-apidiff-release-0-4

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nader-ziada
Copy link
Contributor

lgtm waiting for tests to pass

@nader-ziada
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-release-0-4

@nader-ziada
Copy link
Contributor

@CecileRobertMichon are there any extra tests you want to run here?

@CecileRobertMichon
Copy link
Contributor Author

@nader-ziada the release-0.4 branch doesn't have an e2e test for this (it was added later), I'm running some validation locally, will report back once I have signal

@CecileRobertMichon
Copy link
Contributor Author

@nader-ziada all good 👍 this is ready to go

@nader-ziada
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 957858d into kubernetes-sigs:release-0.4 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awesomenix awesomenix Awaiting requested review from awesomenix

@devigned devigned Awaiting requested review from devigned

Assignees

@nader-ziada nader-ziada

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4.15
Development

Successfully merging this pull request may close these issues.
3 participants
@CecileRobertMichon @k8s-ci-robot @nader-ziada