Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade job should upgrade from 1.20 #1557

Closed
wants to merge 3 commits into from

Conversation

Rahul-D78
Copy link

@Rahul-D78 Rahul-D78 commented Jul 23, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

We should change the KUBERNETES_VERSION_UPGRADE_FROM variable default
in https://github.com/nader-ziada/cluster-api-provider-azure/blob/08f456963fb47f801e75eae730837e3cffe57bfc/test/e2e/config/azure-dev.yaml to v1.20.9 which is the latest 1.20 patch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #1555 , ...) format, will close the issue(s) when PR gets merged):
Fixes #1555

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Rahul-D78. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jul 23, 2021
@CecileRobertMichon
Copy link
Contributor

/ok-to-test
/test pull-cluster-api-provider-azure-capi-e2e

testing the upgrade job

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2021
@CecileRobertMichon
Copy link
Contributor

@Rahul-D78 please link the issue this fixes in the PR description next to "Fixes #"

@CecileRobertMichon
Copy link
Contributor

flake

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2021
@Rahul-D78
Copy link
Author

HI @CecileRobertMichon I have added to issue number is it going to work now

@Rahul-D78
Copy link
Author

/retest

@Rahul-D78
Copy link
Author

/retest-required

@CecileRobertMichon
Copy link
Contributor

the upgrade jobs are still failing, need to investigate what's going on

@@ -103,7 +103,7 @@ variables:
ETCD_VERSION_UPGRADE_TO: "3.4.3-0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rahul-D78 can you please update etcd and coredns versions to:

ETCD_VERSION_UPGRADE_TO: "3.4.13-0"
COREDNS_VERSION_UPGRADE_TO: "1.8.4"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sure

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from cecilerobertmichon after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CecileRobertMichon
Copy link
Contributor

/test pull-cluster-api-provider-azure-capi-e2e

@CecileRobertMichon
Copy link
Contributor

/test pull-cluster-api-provider-azure-capi-e2e

@Rahul-D78
Copy link
Author

Rahul-D78 commented Jul 26, 2021

I have made changes hope It passes all test cases ✔

@CecileRobertMichon
Copy link
Contributor

/retest

just checking if we got unlucky...

@k8s-ci-robot
Copy link
Contributor

@Rahul-D78: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-cluster-api-provider-azure-e2e 4d00d92 link /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-capi-e2e 4d00d92 link /test pull-cluster-api-provider-azure-capi-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CecileRobertMichon
Copy link
Contributor

I was able to repro locally. New upgraded nodes are not becoming ready, investigating.

NAME                                   STATUS     ROLES                  AGE     VERSION
default-template-control-plane-8dhn9   Ready      control-plane,master   17m     v1.20.9
default-template-md-0-hbl5n            Ready      <none>                 15m     v1.20.9
default-template-md-0-qlrqc            NotReady   <none>                 6m49s   v1.21.2
default-template-md-0-vlvnd            Ready      <none>                 14m     v1.20.9

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2021
@Rahul-D78
Copy link
Author

yes thanks for investing .

@CecileRobertMichon
Copy link
Contributor

/close

After investigation (#1568) and per kubernetes-sigs/cluster-api#4896, the failing tests are to be deprecated. Closing this PR in favor of #1566 which will remove these tests.

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closed this PR.

In response to this:

/close

After investigation (#1568) and per kubernetes-sigs/cluster-api#4896, the failing tests are to be deprecated. Closing this PR in favor of #1566 which will remove these tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade job should upgrade from 1.20
3 participants