-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tiltignore to enable auto-update yaml template in Tilt UI #1895
Update tiltignore to enable auto-update yaml template in Tilt UI #1895
Conversation
Hi @djdongjin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@CecileRobertMichon: GitHub didn't allow me to assign the following users: Jont828. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me that this would help if you're changing the yaml templates locally.
Since .tiltignore honors .dockerignore syntax, here's another way to say "ignore everything under templates
except yaml files in that directory":
templates
!templates/*.yaml
It's shorter and maybe a bit more future-proof, but slightly harder to understand. It's just a suggestion; this PR works as-is (I tested it).
@mboersma I agree that your version is more future-proof :). Updated with comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The comments make it perfectly clear--thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks @djdongjin!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
.tilgignore
causes that changes to yaml templates don't trigger re-execution ofTiltfile
. Thus the Tilt UI cannot use updated templates.This PR changes
.tilgignore
to include only subfolders undertemplates
but not.yaml
in the folder, so that Tilt can watch template files. Then if a yaml template is changed, Tilt will notice it and re-executeTiltfile
, thus the new template is used instead of the old one.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1766
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: