✨ Support specifying VM images by ID or from Shared Image Gallery #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
justaugustus
force-pushed
the
image-ref
branch
3 times, most recently
from
46fac45
to
98ca47b
Compare
k8s-ci-robot
added
size/XL
justaugustus
force-pushed
the
image-ref
branch
2 times, most recently
from
dc6260d
to
63caf3c
Compare
k8s-ci-robot
added
size/L
justaugustus
force-pushed
the
image-ref
branch
from
63caf3c
to
7c787e7
Compare
k8s-ci-robot
added
size/XL
justaugustus
changed the title
k8s-ci-robot
added
release-note
justaugustus
changed the title
justaugustus
changed the title
juan-lee
reviewed
Oct 7, 2019
| Offer string `json:"offer"` | ||
| SKU string `json:"sku"` | ||
| Version string `json:"version"` | ||
| Publisher *string `json:"publisher,omitempty"` |
There was a problem hiding this comment.
are these fields optional? If not, the type should be string vs *string.
There was a problem hiding this comment.
@juan-lee -- They're optional-ish. Only required when specifying a published image.
Here's what I wrote for the Image field, which I'm going to write a doc for in short order:
// Image defines information about the image to use for VM creation.
// There are three ways to specify an image: by ID, by publisher, or by Shared Image Gallery.
// If specifying an image by ID, only the ID field needs to be set.
// If specifying an image by publisher, the Publisher, Offer, SKU, and Version fields must be set.
// If specifying an image from a Shared Image Gallery, the SubscriptionID, ResourceGroup,
// Gallery, Name, and Version fields must be set.There was a problem hiding this comment.
Just thinking out loud on how to make this more user friendly. This is where ObjectReference or claim style approach is nice. Each of those permutations could be expressed as a different type. Another option would be for image to have a type and use RuntimeExtension or a map.
There was a problem hiding this comment.
@justaugustus I filed issue #293 to track this improvement in the future.
|
/assign @juan-lee @CecileRobertMichon @vincepri |
k8s-ci-robot
added
the
priority/important-soon
juan-lee
reviewed
Oct 7, 2019
| } | ||
|
|
||
| // generateImageID generates the resource ID for an image stored in an Azure Shared Image Gallery. | ||
| func generateImageID(image infrav1.Image) (string, error) { |
There was a problem hiding this comment.
Don't need to address in this PR, but we should probably enable webhook validation so clients can get errors right away instead of at reconcile time.
There was a problem hiding this comment.
@juan-lee -- Would you mind opening an issue for webhook validation and linking back to this comment?
k8s-ci-robot
added
the
lgtm
justaugustus
force-pushed
the
image-ref
branch
from
7c787e7
to
eaf693b
Compare
k8s-ci-robot
added
size/L
There are now three ways to specify an image: - by ID - by publisher - by Shared Image Gallery. Usage: - If specifying an image by ID, only the ID field needs to be set. - If specifying an image by publisher, the Publisher, Offer, SKU, and Version fields must be set. - If specifying an image from a Shared Image Gallery, the SubscriptionID, ResourceGroup, Gallery, Name, and Version fields must be set. Signed-off-by: Stephen Augustus <saugustus@vmware.com> Co-authored-by: Cecile Robert-Michon <cerobert@microsoft.com>
k8s-ci-robot
added
the
lgtm
justaugustus
force-pushed
the
image-ref
branch
from
eaf693b
to
79c3d1b
Compare
k8s-ci-robot
removed
the
lgtm
|
I've removed the changes to the They're in another branch, if anyone wants to see them. |
justaugustus
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
csrwng
pushed a commit
to csrwng/cluster-api-provider-azure
that referenced
this pull request
Jan 12, 2024
…ency-openshift-4.15-ose-azure-cluster-api-controllers OCPBUGS-24091: Updating ose-azure-cluster-api-controllers-container image to be consistent with ART
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Augustus saugustus@vmware.com
Co-authored-by: Cecile Robert-Michon cerobert@microsoft.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: