Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 book: add documentation regarding storage drivers #925

Merged
merged 1 commit into from Sep 30, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 5, 2020

What this PR does / why we need it:
Draft documentation for storage drivers

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #897

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

book: add documentation regarding storage drivers

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider labels Sep 5, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 5, 2020
After control plane is up and running, deploy the CSI Driver:

```bash
kubectl --kubeconfig=./${CLUSTER_NAME}.kubeconfig \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is correct, I'm not sure if we want to add the manifests on our side.
I prefer to point to the repo and refer the install docs from those repos.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CecileRobertMichon CecileRobertMichon added this to Review in progress in Cluster API Azure Sep 8, 2020
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andyzhangx @chewong can you please help review this?

cpu: 10m
memory: 20Mi
- name: azuredisk
image: mcr.microsoft.com/k8s/csi/azuredisk-csi:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have switched to a different repo for both azuredisk-csi-driver and azurefile-csi-driver images:

Suggested change
image: mcr.microsoft.com/k8s/csi/azuredisk-csi:latest
image: mcr.microsoft.com/oss/kubernetes-csi/azuredisk-csi:master

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better add a install csi driver link here, otherwise you need to maintain those manifests from time to time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer too, @CecileRobertMichon what do you think? Instead of we have the manifests in our repo we just point to the azure-csi ones?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes +1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CecileRobertMichon ok, made the changes

templates/addons/azurefile-csi-driver.yaml Outdated Show resolved Hide resolved
docs/book/src/topics/external-cloud-provider.md Outdated Show resolved Hide resolved
docs/book/src/topics/external-cloud-provider.md Outdated Show resolved Hide resolved
docs/book/src/topics/external-cloud-provider.md Outdated Show resolved Hide resolved
docs/book/src/topics/external-cloud-provider.md Outdated Show resolved Hide resolved
docs/book/src/topics/external-cloud-provider.md Outdated Show resolved Hide resolved
docs/book/src/topics/external-cloud-provider.md Outdated Show resolved Hide resolved
docs/book/src/topics/external-cloud-provider.md Outdated Show resolved Hide resolved
docs/book/src/topics/external-cloud-provider.md Outdated Show resolved Hide resolved
docs/book/src/topics/external-cloud-provider.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2020
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@nader-ziada
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e

@k8s-ci-robot k8s-ci-robot merged commit 2ef2045 into kubernetes-sigs:master Sep 30, 2020
Cluster API Azure automation moved this from Review in progress to Done (2020 - Q2) Sep 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.4.9 milestone Sep 30, 2020
@cpanato cpanato deleted the GH-897 branch September 30, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Cluster API Azure
  
Done (2020 - Q2)
Development

Successfully merging this pull request may close these issues.

Document installing OOT storage drivers
7 participants