New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摉 book: add documentation regarding storage drivers #925
Conversation
After control plane is up and running, deploy the CSI Driver: | ||
|
||
```bash | ||
kubectl --kubeconfig=./${CLUSTER_NAME}.kubeconfig \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is correct, I'm not sure if we want to add the manifests on our side.
I prefer to point to the repo and refer the install docs from those repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyzhangx @chewong can you please help review this?
cpu: 10m | ||
memory: 20Mi | ||
- name: azuredisk | ||
image: mcr.microsoft.com/k8s/csi/azuredisk-csi:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have switched to a different repo for both azuredisk-csi-driver and azurefile-csi-driver images:
image: mcr.microsoft.com/k8s/csi/azuredisk-csi:latest | |
image: mcr.microsoft.com/oss/kubernetes-csi/azuredisk-csi:master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better add a install csi driver link here, otherwise you need to maintain those manifests from time to time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer too, @CecileRobertMichon what do you think? Instead of we have the manifests in our repo we just point to the azure-csi ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes +1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CecileRobertMichon ok, made the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-provider-azure-e2e |
What this PR does / why we need it:
Draft documentation for storage drivers
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #897
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: