New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Migrate dep to go modules #137
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joonas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
64b63b8
to
98c9973
Compare
@joonas: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I reckon it would be best to get #138 merged in before proceeding with this one. |
this PR is still active? what we need to do to move forward? |
@cpanato @joonas This PR depends on #138. Since we are migrating to CAPI I'm planning to do a snapshot of the current master ( |
@xmudrii if we will not change this anymore maybe doe snot worth to effort to get this and the other merged and focus on that v1alpha2 |
Closing this PR in favor of #140. |
@xmudrii: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Go modules have become the standard way to manage dependencies across the various cluster-api (capi, capa, capz, capg, capo) projects. It seems to me that it would make sense to follow suit for the sake of standardizing.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Documentation:
Release note: