Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate dep to go modules #137

Closed

Conversation

joonas
Copy link

@joonas joonas commented Nov 22, 2019

What this PR does / why we need it:

Go modules have become the standard way to manage dependencies across the various cluster-api (capi, capa, capz, capg, capo) projects. It seems to me that it would make sense to follow suit for the sake of standardizing.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 22, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 22, 2019
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joonas
To complete the pull request process, please assign alvaroaleman
You can assign the PR to them by writing /assign @alvaroaleman in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

k8s-ci-robot commented Nov 22, 2019

@joonas: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-api-provider-digitalocean-lint fac8fea link /test pull-cluster-api-provider-digitalocean-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alvaroaleman alvaroaleman removed their request for review November 22, 2019 16:45
@joonas
Copy link
Author

joonas commented Nov 23, 2019

I reckon it would be best to get #138 merged in before proceeding with this one.

@cpanato
Copy link
Member

cpanato commented Feb 12, 2020

this PR is still active? what we need to do to move forward?

@xmudrii
Copy link
Member

xmudrii commented Feb 12, 2020

@cpanato @joonas This PR depends on #138. Since we are migrating to CAPI v1alpha2 which brings significant changes to the project and includes both this PR and #138, should we close this PR or merge it anyways?

I'm planning to do a snapshot of the current master (v1alpha1) and then I think we will not accept any changes afterward. If you'd like to see gometalinter and Go modules in the v1alpha1 version, then we can merge both PRs, otherwise, I'll eventually close them.

@cpanato
Copy link
Member

cpanato commented Feb 12, 2020

@xmudrii if we will not change this anymore maybe doe snot worth to effort to get this and the other merged and focus on that v1alpha2

@xmudrii
Copy link
Member

xmudrii commented Mar 12, 2020

Closing this PR in favor of #140.
/close

@k8s-ci-robot
Copy link

@xmudrii: Closed this PR.

In response to this:

Closing this PR in favor of #140.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants