✨ Support bootstrap data in secret #270
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
vincepri
force-pushed
the
bootstra-data-secret
branch
2 times, most recently
from
5eceafc
to
ddc9414
Compare
There was a problem hiding this comment.
tried running it and got the following error:
Failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:capg-system:default" cannot list resource "secrets" in API group "" at the cluster scope
It missing the secrets resource in the config/rbac/role.yaml file
- apiGroups:
- ""
resources:
- secrets
verbs:
- get
- list
- watch
There was a problem hiding this comment.
After adding the secrets role in my local copy got the following error
E1217 09:42:18.186343 1 conversion.go:76] conversion-webhook "msg"="failed to convert" "error"="cannot convert KubeadmConfigStatus's bootstrap data from Secret reference to inline field" "request"="527573f9-3d4c-47e2-9803-f7aeb512c77f"
|
The second error seems it's related to converting v1a3 -> v1a2, which isn't supported |
vincepri
force-pushed
the
bootstra-data-secret
branch
from
ddc9414
to
2619fce
Compare
cloud/scope/machine.go
Outdated
| secret := &corev1.Secret{} | ||
| key := types.NamespacedName{Namespace: m.Namespace(), Name: *m.Machine.Spec.Bootstrap.DataSecretName} | ||
| if err := m.client.Get(context.TODO(), key, secret); err != nil { | ||
| return "", errors.Wrapf(err, "failed to retrieve bootstrap data secret for AWSMachine %s/%s", m.Namespace(), m.Name()) |
Signed-off-by: Vince Prignano <vincepri@vmware.com>
vincepri
force-pushed
the
bootstra-data-secret
branch
from
2619fce
to
bd17a71
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Vince Prignano vincepri@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #