Add shared VPC networking #991

bighiro · 2023-07-27T13:33:28Z

What type of PR is this?
/kind feature

What this PR does / why we need it:

Support shared VPC networking.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #861 #982

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

Support shared VPC networking.
Able to deploy the cluster with shared VPC network from another project that hosts the networks.

k8s-ci-robot · 2023-07-27T13:33:33Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bighiro
Once this PR has been reviewed and has the lgtm label, please assign cecilerobertmichon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-07-27T13:33:37Z

Hi @bighiro. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richardcase · 2023-08-15T15:11:46Z

/ok-to-test

k8s-ci-robot · 2023-08-15T15:14:39Z

@bighiro: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-gcp-apidiff	`53a8cb0`	link	false	`/test pull-cluster-api-provider-gcp-apidiff`
pull-cluster-api-provider-gcp-verify	`53a8cb0`	link	true	`/test pull-cluster-api-provider-gcp-verify`
pull-cluster-api-provider-gcp-test	`53a8cb0`	link	true	`/test pull-cluster-api-provider-gcp-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

richardcase · 2023-08-15T15:23:42Z

Thanks for this @bighiro 🙇

There are a number of jobs failed. Could you do the following:

make generate
make lint
make test

This will highlight some issues that will need to be fixed. Additionally you will need to update the conversions manually as the new field HostProject is failing in the roundtrip fuzzing tests. You will need to add something similar to this:

cluster-api-provider-gcp/api/v1alpha4/gcpcluster_conversion.go

Line 41 in 53a8cb0

for _, restoredSubnet := range restored.Spec.Network.Subnets {

for the new field so it can be restored.

Reach out here or in our slack channel if you need any help.

akshay196 · 2023-08-16T06:09:23Z

Adding comment as I happened to worked on GKE with shared VPC recently.

This PR will affect the GKE implementation too as NetworkSpec is common for un-managed and managed GCP clusters. One thing I have seen is that it becomes mandatory to provide secondary Pod and Service ranges for GKE (both auto-pilot and standard) if the cluster is using shared VPC. [1]

So we need to verify this PR with GKE too if that is also in focus of this PR.

[1] https://cloud.google.com/kubernetes-engine/docs/how-to/cluster-shared-vpc#verify_usable_subnets

richardcase · 2023-10-26T11:01:58Z

@bighiro - just folllowing up on if you'd be able to review the comments?

k8s-triage-robot · 2024-01-24T11:51:48Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-23T12:14:03Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

barbacbd · 2024-03-22T15:04:29Z

api/v1beta1/types.go

@@ -93,6 +93,9 @@ type NetworkSpec struct {
 	// +optional
 	Name *string `json:"name,omitempty"`

+	// HostProject  is the name of the host project hosting the shared VPC network


Suggested change

// HostProject is the name of the host project hosting the shared VPC network

// HostProject is the name of the host project hosting the shared VPC network resources.

// +optional

barbacbd · 2024-03-22T15:06:09Z

cloud/scope/machine.go

@@ -94,6 +94,11 @@ func (m *MachineScope) Cloud() cloud.Cloud {
 	return m.ClusterGetter.Cloud()
 }

+// NetworkCloud returns initialized network cloud


Suggested change

// NetworkCloud returns initialized network cloud

// NetworkCloud returns initialized network cloud.

barbacbd · 2024-03-22T15:08:49Z

cloud/scope/managedcluster.go

+
+// IsSharedVpc returns the cluster network unique identifier.
+func (s *ManagedClusterScope) IsSharedVpc() bool {
+	if s.NetworkProject() != s.Project() {


nit:

Suggested change

if s.NetworkProject() != s.Project() {

return s.NetworkProject() != s.Project

barbacbd · 2024-03-22T15:11:50Z

cloud/services/compute/subnets/reconcile.go

@@ -41,6 +41,9 @@ func (s *Service) Reconcile(ctx context.Context) error {
 // Delete deletes cluster subnetwork components.
 func (s *Service) Delete(ctx context.Context) error {
 	logger := log.FromContext(ctx)
+	if s.scope.IsSharedVpc() {
+		return nil


Nit: Log/Alert that this is a shared VPC.

This is an update to the stale PR kubernetes-sigs#991 ** Added support for Host Project for a shared VPC in the Network struct. ** Network Resources will now use the host project name if exists, otherwise the normal project. ** Update the cluster getter interface to include the NetworkProject and Indicator for a shared VPC. ** Update reconcilers for girewall rules, subnets and network. ** Update the services to use the host project for resources when a shared vpc is used.

k8s-triage-robot · 2024-04-21T16:10:55Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-04-21T16:11:00Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Add shared VPC networking

53a8cb0

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 27, 2023

k8s-ci-robot requested review from cpanato and dims July 27, 2023 13:33

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 27, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 24, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 23, 2024

barbacbd reviewed Mar 22, 2024

View reviewed changes

barbacbd mentioned this pull request Mar 22, 2024

Add support for Shared VPC Networking #1189

Open

3 tasks

k8s-ci-robot closed this Apr 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add shared VPC networking #991

Add shared VPC networking #991

bighiro commented Jul 27, 2023

k8s-ci-robot commented Jul 27, 2023

k8s-ci-robot commented Jul 27, 2023

richardcase commented Aug 15, 2023

k8s-ci-robot commented Aug 15, 2023

richardcase commented Aug 15, 2023

akshay196 commented Aug 16, 2023

richardcase commented Oct 26, 2023

k8s-triage-robot commented Jan 24, 2024

k8s-triage-robot commented Feb 23, 2024

barbacbd Mar 22, 2024

barbacbd Mar 22, 2024

barbacbd Mar 22, 2024

barbacbd Mar 22, 2024

k8s-triage-robot commented Apr 21, 2024

k8s-ci-robot commented Apr 21, 2024

	// HostProject is the name of the host project hosting the shared VPC network
	// HostProject is the name of the host project hosting the shared VPC network resources.
	// +optional

	// NetworkCloud returns initialized network cloud
	// NetworkCloud returns initialized network cloud.

	if s.NetworkProject() != s.Project() {
	return s.NetworkProject() != s.Project

Add shared VPC networking #991

Add shared VPC networking #991

Conversation

bighiro commented Jul 27, 2023

k8s-ci-robot commented Jul 27, 2023

k8s-ci-robot commented Jul 27, 2023

richardcase commented Aug 15, 2023

k8s-ci-robot commented Aug 15, 2023

richardcase commented Aug 15, 2023

akshay196 commented Aug 16, 2023

richardcase commented Oct 26, 2023

k8s-triage-robot commented Jan 24, 2024

k8s-triage-robot commented Feb 23, 2024

barbacbd Mar 22, 2024

Choose a reason for hiding this comment

barbacbd Mar 22, 2024

Choose a reason for hiding this comment

barbacbd Mar 22, 2024

Choose a reason for hiding this comment

barbacbd Mar 22, 2024

Choose a reason for hiding this comment

k8s-triage-robot commented Apr 21, 2024

k8s-ci-robot commented Apr 21, 2024