Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM Cloud Kubernetes Service provider support #86

Closed
xunpan opened this issue Apr 30, 2019 · 13 comments
Closed

IBM Cloud Kubernetes Service provider support #86

xunpan opened this issue Apr 30, 2019 · 13 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@xunpan
Copy link
Contributor

xunpan commented Apr 30, 2019

/kind feature

Describe the solution you'd like
IBM Cloud Kubernetes Service provider support

@gyliu513
Copy link
Contributor

gyliu513 commented May 5, 2019

@dcberg

@gyliu513
Copy link
Contributor

gyliu513 commented May 7, 2019

We probably need to integrate with IKS like what openstack is doing now as configured at https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/cmd/clusterctl/examples/openstack/provider-component/user-data/ubuntu/templates/master-user-data.sh#L139-L141

nodeRegistration:
  criSocket: /var/run/dockershim.sock
  kubeletExtraArgs:
    cloud-config: /etc/kubernetes/cloud.conf
    cloud-provider: openstack

@jichenjc can you help do some investigate for this, since you also worked for https://github.com/kubernetes/kubernetes/tree/master/pkg/cloudprovider before?

@dcberg @rtheis please show your comments if any.

FYI @hchenxa

@jichenjc
Copy link
Contributor

jichenjc commented May 7, 2019

ok, I will dig this and see what I can do and may consult with cloud provider openstack a little bit
( the progress will be a little bit slow this week due to external conference in US)

@gyliu513
Copy link
Contributor

gyliu513 commented May 7, 2019

@rtheis is the owner for IBM Cloud Provider at https://github.com/kubernetes/kubernetes/tree/master/pkg/cloudprovider , we can get some comments from him as well.

FYI @mdelder @spzala

@jichenjc
Copy link
Contributor

@xunpan @gyliu513 @spzala I did some analaysis here, I worked on https://github.com/kubernetes/cloud-provider-openstack a little bit before and know basic parts there, but I don't fully sure the connections and usage between cloud provider and cluster-api ,at least seems cluster-api-provider-openstack doesn't use cloud provider for now...

so what should we do ? maybe just follow the openstack to add cloud provider info into spawned VM and that's all? I can dig more but if you already know something, please share, thanks

@gyliu513
Copy link
Contributor

@jichenjc not sure if we can leverage IKS to provision VMs with k8s installed when using Cluster API?

@hchenxa comments for this?

@rtheis
Copy link

rtheis commented May 30, 2019

IBM Cloud Kubernetes Service (IKS) handles provisioning and configuring the IBM cloud provider using the Kubernetes controller manager architecture. That is, the cloud provider is internal, not external. Given that IBM's cloud provider code is not yet open source and that it is moving to the cloud controller manager architecture, it will be difficult support the IBM cloud-config, cloud-provider and related configuration options in the cluster API at this time.

@gyliu513
Copy link
Contributor

Thanks @rtheis , this make sense. The Cluster API is mainly focusing on IaaS cloud to manage the k8s clusters, not sure if this provider can leverage IKS to provide functions like LoadBalacer etc.

FYI @xunpan @hchenxa for more comments.

@jichenjc
Copy link
Contributor

that's my assumption as well, cloud-provider-xxx and cluster-api-provider may use some code but should not provide simliar function, what's the use case to create LB in cluster-api provider? I think we need first create cluster then define LB against the new cluster but that's another step..

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 29, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 28, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants