Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [VC] Support Staging Releases for VC code base #129

Open
christopherhein opened this issue Jun 15, 2021 · 5 comments
Open

✨ [VC] Support Staging Releases for VC code base #129

christopherhein opened this issue Jun 15, 2021 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@christopherhein
Copy link
Member

User Story

As a user I would like to be able to use VC with CAPN from Prow based builds for so that I can use automated and "blessed" images.

Detailed Description

Right now CAPN is released every main branch merge plus, this is done using the make release-staging target, we should update these downstream targets to add CAPN into this.

Anything else you would like to add:

This doesn't need to deal with the manifests, this will be handled in the make release changes.

/kind feature
/milestone v0.1.x

@k8s-ci-robot k8s-ci-robot added this to the v0.1.x milestone Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 15, 2021
@christopherhein
Copy link
Member Author

/retitle ✨ [VC] Support Staging Releases for VC code base

@nobody4t
Copy link

@christopherhein
Want to confirm with you that: the target here is to:

Whenever there is code merge in virtualcluster, the image build should also trigger from CAPN by make release?

Because you said: this will be handled in the make release changes.
But what if there is no release at the time when the code changes happened in virutalcluster?
Should we also handle this for staging release?

And btw, I did not find any steps for prod images pushing.
The release tag just updates the manifests. Did I miss anything?

@christopherhein
Copy link
Member Author

The target of this issue is to handle the staging releases similar to what we have in capn/Makefile under the target make staging-release but integrated to work against VC code base, this will make it so that every merge into main will get a sha based release that we can then verify with. For the prod releases it's actually not automated via prow, what we do is follow the guide https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/developer/releasing.md to make sure we tag the release locally and then rerun the make release target to generate the production ready manifests, once those are built and the stage was pushed we manually make a Github release and upload the production manifests that were generated locally.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2021
@christopherhein
Copy link
Member Author

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants